Re: [PATCH net-next v5 5/5] net/smc: Add global configure for auto fallback by netlink

Tony Lu
2022-02-09T09:22:44Z

On Tue, Feb 08, 2022 at 08:53:13PM +0800, D. Wythe wrote:
> From: "D. Wythe" <alibuda@linux.alibaba.com>
>
> @@ -248,6 +248,8 @@ int smc_nl_get_sys_info(struct sk_buff *skb, struct netlink_callback *cb)
> goto errattr;
> if (nla_put_u8(skb, SMC_NLA_SYS_IS_SMCR_V2, true))
> goto errattr;
> + if (nla_put_u8(skb, SMC_NLA_SYS_AUTO_FALLBACK, smc_auto_fallback))

READ_ONCE(smc_auto_fallback) ?

> + goto errattr;
> smc_clc_get_hostname(&host);
> if (host) {
> memcpy(hostname, host, SMC_MAX_HOSTNAME_LEN);
> diff --git a/net/smc/smc_netlink.c b/net/smc/smc_netlink.c
> index f13ab06..a7de517 100644
> --- a/net/smc/smc_netlink.c
> +++ b/net/smc/smc_netlink.c
> @@ -111,6 +111,16 @@
> .flags = GENL_ADMIN_PERM,
> .doit = smc_nl_disable_seid,
> },
> + {
> + .cmd = SMC_NETLINK_ENABLE_AUTO_FALLBACK,
> + .flags = GENL_ADMIN_PERM,
> + .doit = smc_enable_auto_fallback,
> + },
> + {
> + .cmd = SMC_NETLINK_DISABLE_AUTO_FALLBACK,
> + .flags = GENL_ADMIN_PERM,
> + .doit = smc_disable_auto_fallback,
> + },
> };

Consider adding the separated cmd to query the status of this config,
just as SEID does?

It is common to check this value after user-space setted. Combined with
sys_info maybe a little heavy in this scene.

Thanks,
Tony Lu