Re: [PATCH 23/30] printk: kmsg_dump: Introduce helper to inform number of dumpers

Steven Rostedt
2022-05-10T17:40:29Z

On Wed, 27 Apr 2022 19:49:17 -0300
"Guilherme G. Piccoli" <gpiccoli@igalia.com> wrote:

> Currently we don't have a way to check if there are dumpers set,
> except counting the list members maybe. This patch introduces a very
> simple helper to provide this information, by just keeping track of
> registered/unregistered kmsg dumpers. It's going to be used on the
> panic path in the subsequent patch.

FYI, it is considered "bad form" to reference in the change log "this
patch". We know this is a patch. The change log should just talk about what
is being done. So can you reword your change logs (you do this is almost
every patch). Here's what I would reword the above to be:

Currently we don't have a way to check if there are dumpers set, except
perhaps by counting the list members. Introduce a very simple helper to
provide this information, by just keeping track of registered/unregistered
kmsg dumpers. This will simplify the refactoring of the panic path.

-- Steve