RE: [PATCH v1 13/18] vfio/mdev: Consolidate all the device_api sysfs into the core code

Tian, Kevin
2022-06-10T07:22:54Z

> From: Eric Farman
> Sent: Friday, June 3, 2022 1:20 AM
>
> From: Jason Gunthorpe <jgg@nvidia.com>
>
> Every driver just emits a static string, simply feed it through the ops
> and provide a standard sysfs show function.
>
> Cc: Kirti Wankhede <kwankhede@nvidia.com>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: Zhi Wang <zhi.a.wang@intel.com>
> Cc: Tony Krowiak <akrowiak@linux.ibm.com>
> Cc: Jason Herne <jjherne@linux.ibm.com>
> Cc: intel-gvt-dev@lists.freedesktop.org
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Link: https://lore.kernel.org/r/6-v3-57c1502c62fd+2190-
> ccw_mdev_jgg@nvidia.com/
> [farman: added Cc: tags]
> Signed-off-by: Eric Farman <farman@linux.ibm.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>, with one nit:

> @@ -225,7 +226,8 @@ Directories and files under the sysfs for Each Physical
> Device
> * device_api
>
> This attribute should show which device API is being created, for example,
> - "vfio-pci" for a PCI device.
> + "vfio-pci" for a PCI device. The core code maintins this sysfs using the
> + device_api member of mdev_parent_ops.
>

s/maintins/maintains/