From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FED8ECAAD3 for ; Wed, 31 Aug 2022 08:59:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231694AbiHaI7A (ORCPT ); Wed, 31 Aug 2022 04:59:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231927AbiHaI6k (ORCPT ); Wed, 31 Aug 2022 04:58:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA5DAD4C for ; Wed, 31 Aug 2022 01:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661936311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IW7RubSZwqNRNbVodwb3pZqFVO6G5hQjn6X5TjkRm1w=; b=NSJIPw61DGlWdE7KKZsQVTaF3XsUx7KsxQTLAOwVIfpidLSeqwx/5YxhZSYK+B5PdFsorr E3SPTRlgkIA9C85YRxz8eiyGa1HMvIxByzKiP4RqlmyQ4qRgTsEGgREoXqKJ8fVP2SJzMF RxezqOlOWtfSJACrSaxStrgoRhyHgd4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-441-AgF2O633Mp-aThUtOrfFtw-1; Wed, 31 Aug 2022 04:58:27 -0400 X-MC-Unique: AgF2O633Mp-aThUtOrfFtw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8993A8517FB; Wed, 31 Aug 2022 08:58:23 +0000 (UTC) Received: from localhost (ovpn-13-50.pek2.redhat.com [10.72.13.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 509481454547; Wed, 31 Aug 2022 08:58:21 +0000 (UTC) Date: Wed, 31 Aug 2022 16:58:18 +0800 From: Baoquan He To: Niklas Schnelle Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Subject: Re: [PATCH v2 09/11] s390: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20220820003125.353570-1-bhe@redhat.com> <20220820003125.353570-10-bhe@redhat.com> <3a797c5ccde91c7791b3bdd3d81391a8fb38f2c5.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a797c5ccde91c7791b3bdd3d81391a8fb38f2c5.camel@linux.ibm.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 08/22/22 at 05:19pm, Niklas Schnelle wrote: > On Sat, 2022-08-20 at 08:31 +0800, Baoquan He wrote: > > Add hooks arch_ioremap() and arch_iounmap() for s390's special > > operation when ioremap() and iounmap(), then ioremap_[wc|wt]() are > > converted to use ioremap_prot() from GENERIC_IOREMAP. > > > > Signed-off-by: Baoquan He > > Cc: Heiko Carstens > > Cc: Vasily Gorbik > > Cc: Alexander Gordeev > > Cc: Christian Borntraeger > > Cc: Sven Schnelle > > Cc: linux-s390@vger.kernel.org > > --- > > arch/s390/Kconfig | 1 + > > arch/s390/include/asm/io.h | 26 +++++++++++------ > > arch/s390/pci/pci.c | 60 +++++--------------------------------- > > 3 files changed, 26 insertions(+), 61 deletions(-) > > Sorry I missed this mail until now and will still need a bit of time to > review and test the code as this is indeed pretty special on s390. From > a first glance this does look like a nice simplification. > > Just out of curiosity, I wonder why get_maintainers.pl didn't add me > nor Gerald for direct CC despite the bulk of the changes affecting > arch/s390/pci/*. I run below script again, it does print you and Gerald's name in the list. It must be me who made mistake when copying maintainers' name into Cc. Sorry about that. ./scripts/get_maintainer.pl 0009-s390-mm-Convert-to-GENERIC_IOREMAP.patch > > > > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > ---8<--- >