From: Jason Gunthorpe <jgg@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Eric Farman <farman@linux.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
Matthew Rosato <mjrosato@linux.ibm.com>
Subject: Re: [PATCH 1/2] vfio/pci: Split linux/vfio_pci_core.h
Date: Fri, 26 Aug 2022 15:32:26 -0300 [thread overview]
Message-ID: <YwkRurCNZDlNvSyS@nvidia.com> (raw)
In-Reply-To: <BN9PR11MB527610FD13AEB17B5C98DB7E8C719@BN9PR11MB5276.namprd11.prod.outlook.com>
On Mon, Aug 22, 2022 at 04:22:17AM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Wednesday, August 17, 2022 11:30 PM
> >
> > +/* Will be exported for vfio pci drivers usage */
> > int vfio_pci_register_dev_region(struct vfio_pci_core_device *vdev,
> > unsigned int type, unsigned int subtype,
> > const struct vfio_pci_regops *ops,
> > size_t size, u32 flags, void *data);
>
> NIT. This wants to follow the convention of other exported symbols
> in following line i.e. having 'vfio_pci_core_' as the prefix.
I added a patch for this
Thanks,
Jason
next prev parent reply other threads:[~2022-08-26 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 15:29 [PATCH 0/2] Remove private items from linux/vfio_pci_core.h Jason Gunthorpe
2022-08-17 15:29 ` [PATCH 1/2] vfio/pci: Split linux/vfio_pci_core.h Jason Gunthorpe
2022-08-22 4:22 ` Tian, Kevin
2022-08-26 18:32 ` Jason Gunthorpe [this message]
2022-08-17 15:29 ` [PATCH 2/2] vfio/pci: Simplify the is_intx/msi/msix/etc defines Jason Gunthorpe
2022-08-22 4:24 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwkRurCNZDlNvSyS@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).