From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B490EECAAD8 for ; Wed, 21 Sep 2022 16:29:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232410AbiIUQ3V (ORCPT ); Wed, 21 Sep 2022 12:29:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232435AbiIUQ3C (ORCPT ); Wed, 21 Sep 2022 12:29:02 -0400 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 730E8B533D for ; Wed, 21 Sep 2022 09:10:59 -0700 (PDT) Received: by mail-qt1-x836.google.com with SMTP id cj27so4433080qtb.7 for ; Wed, 21 Sep 2022 09:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=AMTftBiMWZk2QAmHkrehOI1g5/daemu3hoROzAqo87c=; b=f/UulgVbJR9/vOmsWbt5U91/tnOJo2PNL7TKCK8SY11JbGK+VrMoYbcJhcnMEmf5jQ EovlYjMoktLgNatoK+CVy/Rs7kyV2UA6+8pOZJO7l4anbiUth706rX7MVcJm2FurqfvZ qefHdqd0c/ho17jos0I/MwJ0GFfLtiSQFIshBUoETfF+JIBKx/dTEV8P4MJcgAKTCfgw iOPIc2rXvMSMMVwnmZz1ld8coHSm6IkjdCY6psHq+gvZXV66Pty8+C6P9UseXBXGvQ70 r4tkHYuAgGQJeczB7XpAp+Yau+TWBCZJuVUu2BM/CB1qYJNCkA9RyP2l842CVcM2rxWG DOzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=AMTftBiMWZk2QAmHkrehOI1g5/daemu3hoROzAqo87c=; b=qiWaop6BI0MHghYXdVREar+6jYXRXfWkUB3Oxn3dTEYRSMQwAgb9rO3MgH9RgssqSh xPJ2pbOF8Tqa5UF252kqFoG37yECFK7+ALYwU3baHYE3NHtJ0G7fQo3iyTbAgtxvOetM t36w4SYepiXTAklzsBxxeJd2tO3Bpn+8q7SENo16EHniWG7kOyCQFj4zK71w8S3oPJu9 VmkUbDmxuBmZGXgLCzpGL7yNdWh+BxLoHFCqolwYDdbynbuHypRuOnH5oc9KB97ofdVV 2P2WrBJv2qlpqbFrdsG52QmJdgj/20JEPRA/M+Cep4Yeo83varvNe5pobhcpyZ/TnSxS UzkQ== X-Gm-Message-State: ACrzQf18HHByH7OeQ6pilqqUcHYClq73rQi52qa/fn32dxyFktJeGY3U kmFM7mq9tMsYP7H7GHKZbxARNQ== X-Google-Smtp-Source: AMsMyM6D2XVUjaEeXTE0RkRp6giqAEccP/ds63pJ2ySWLbtpckoAq+4dbYsu8/rqDg2Hj9+Vy46RKw== X-Received: by 2002:ac8:7d10:0:b0:35c:d519:545 with SMTP id g16-20020ac87d10000000b0035cd5190545mr20896336qtb.537.1663776631727; Wed, 21 Sep 2022 09:10:31 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id l3-20020a05620a28c300b006b872b606b1sm2199206qkp.128.2022.09.21.09.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 09:10:30 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1ob2Iv-000qCI-Hh; Wed, 21 Sep 2022 13:10:29 -0300 Date: Wed, 21 Sep 2022 13:10:29 -0300 From: Jason Gunthorpe To: "Tian, Kevin" Cc: Alex Williamson , Zhenyu Wang , "Wang, Zhi A" , Jani Nikula , Joonas Lahtinen , "Vivi, Rodrigo" , Tvrtko Ursulin , David Airlie , Daniel Vetter , Eric Farman , Matthew Rosato , Halil Pasic , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Tony Krowiak , Jason Herne , Harald Freudenberger , Diana Craciun , Cornelia Huck , Longfang Liu , Shameer Kolothum , Yishai Hadas , Eric Auger , Kirti Wankhede , Leon Romanovsky , Abhishek Sahu , Christoph Hellwig , "intel-gvt-dev@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-s390@vger.kernel.org" , "kvm@vger.kernel.org" , "Liu, Yi L" Subject: Re: [PATCH v3 15/15] vfio: Add struct device to vfio_device Message-ID: References: <20220909102247.67324-1-kevin.tian@intel.com> <20220909102247.67324-16-kevin.tian@intel.com> <20220920142639.29b1bdc2.alex.williamson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Tue, Sep 20, 2022 at 10:55:40PM +0000, Tian, Kevin wrote: > > From: Alex Williamson > > Sent: Wednesday, September 21, 2022 4:27 AM > > > > On Fri, 9 Sep 2022 18:22:47 +0800 > > Kevin Tian wrote: > > > > > From: Yi Liu > > > > > > and replace kref. With it a 'vfio-dev/vfioX' node is created under the > > > sysfs path of the parent, indicating the device is bound to a vfio > > > driver, e.g.: > > > > > > /sys/devices/pci0000\:6f/0000\:6f\:01.0/vfio-dev/vfio0 > > > > > > It is also a preparatory step toward adding cdev for supporting future > > > device-oriented uAPI. > > > > > > Add Documentation/ABI/testing/sysfs-devices-vfio-dev. > > > > > > Also take this chance to rename chardev 'vfio' to 'vfio-group' in > > > /proc/devices. > > > > What's the risk/reward here, is this just more aesthetically pleasing > > symmetry vs 'vfio-dev'? The char major number to name association in > > /proc/devices seems pretty obscure, but what due diligence have we done > > to make sure this doesn't break anyone? Thanks, > > I'm not sure whether the content of /proc/devices is considered as ABI. > > @Jason? Ah, I've forgotten why we got here - didn't we have a naming conflict with the new stuff that is being introduced? ABI wise it is not a problem unless there is a real user, I'm not aware of anything scanning /proc, that has been obsoleted by sysfs a long time ago. Jason