Re: [PATCH v2 2/3] s390/pci: remove unused bus_next field from struct zpci_dev

Pierre Morel
2022-09-26T09:21:18Z

On 9/22/22 11:52, Niklas Schnelle wrote:
> This field was added in commit 44510d6fa0c0 ("s390/pci: Handling
> multifunctions") but is an unused remnant of an earlier version where
> the devices on the virtual bus were connected in a linked list instead
> of a fixed 256 entry array of pointers.
>
> It is also not used for the list of busses as that is threaded through
> struct zpci_bus not through struct zpci_dev.
>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>

Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>

> ---
> arch/s390/include/asm/pci.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/s390/include/asm/pci.h b/arch/s390/include/asm/pci.h
> index 7b4cdadbc023..108e732d7b14 100644
> --- a/arch/s390/include/asm/pci.h
> +++ b/arch/s390/include/asm/pci.h
> @@ -117,7 +117,6 @@ struct zpci_bus {
> struct zpci_dev {
> struct zpci_bus *zbus;
> struct list_head entry; /* list of all zpci_devices, needed for hotplug, etc. */
> - struct list_head bus_next;
> struct kref kref;
> struct hotplug_slot hotplug_slot;
>

--
Pierre Morel
IBM Lab Boeblingen