Re: [PATCH net-next v4] net/smc: Use percpu ref for wr tx reference

Tony Lu
2023-03-15T08:27:13Z

On Wed, Mar 15, 2023 at 12:34:40AM -0700, Jakub Kicinski wrote:
> On Mon, 13 Mar 2023 06:04:25 +0000 Kai wrote:
> > Signed-off-by: Kai <KaiShen@linux.alibaba.com>
>
> Kai Shen ?
>
> >
>
> You're missing a --- separator here, try to apply this patch with
> git am :/

There is another commit ce7ca794712f ("net/smc: fix fallback failed
while sendmsg with fastopen") that has been merged that also has this
problem. Maybe we can add some scripts to check this?

>
> > v1->v2:
> > - Modify patch prefix
> >
> > v2->v3:
> > - Make wr_reg_refcnt a percpu one as well
> > - Init percpu ref with 0 flag instead of ALLOW_REINIT flag
> >
> > v3->v4:
> > - Update performance data, this data may differ from previous data
> > as I ran cases on other machines
> > ---