Re: [PATCH] s390/net: lcs: use IS_ENABLED() for kconfig detection

Randy Dunlap
2023-06-21T21:19:20Z

On 6/21/23 12:37, Simon Horman wrote:
> On Wed, Jun 21, 2023 at 11:08:05AM -0700, Randy Dunlap wrote:
>> Hi Simon,
>>

>>> I did have better luck with this.
>>>
>>> diff --git a/drivers/s390/net/Kconfig b/drivers/s390/net/Kconfig
>>> index 9c67b97faba2..303220251495 100644
>>> --- a/drivers/s390/net/Kconfig
>>> +++ b/drivers/s390/net/Kconfig
>>> @@ -6,6 +6,7 @@ config LCS
>>> def_tristate m
>>> prompt "Lan Channel Station Interface"
>>> depends on CCW && NETDEVICES && (ETHERNET || FDDI)
>>> + depends on FDDI=y || FDDI=n
>>> help
>>> Select this option if you want to use LCS networking on IBM System z.
>>> This device driver supports FDDI (IEEE 802.7) and Ethernet.
>>>
>>> I am assuming that LCS=m and FDDI=m can't work at runtime
>>> because there is no guarantee that FDDI is loaded before LCS.
>>> But I could well be wrong here.
>>
>> There's probably some way to make that work, but I don't know.
>>
>> I think that your patch is acceptable.
>> I would prefer to also add to the help text that if FDDI is used,
>> it must be builtin (=y).
>
> Thanks Randy,
>
> Feel free to take the snippet above and work it into a proper patch.
> Else I can take a shot at it.
>

OK, I'll send that. Thanks.

--
~Randy