Re: [PATCH v6 07/25] iommu/mtk_iommu_v1: Implement an IDENTITY domain

Baolu Lu
2023-08-15T00:35:19Z

On 2023/8/14 22:34, Jason Gunthorpe wrote:
>>> @@ -443,7 +459,7 @@ static int mtk_iommu_v1_create_mapping(struct device *dev, struct of_phandle_arg
>>> static int mtk_iommu_v1_def_domain_type(struct device *dev)
>>> {
>>> - return IOMMU_DOMAIN_UNMANAGED;
>>> + return IOMMU_DOMAIN_IDENTITY;
>> def_domain_type can't be used for this purpose. But this seems to be a
>> temporary code, as it will be removed in patch 09/25.
> It looked OK when I checked it, mkt_v1 is really confusing what it
> tries to do, but it should call probe_finalize and basically do the
> same hacky thing as what UNMANAGED was trying to accomplish.
>
> Did you see something else?

No.

Best regards,
baolu