Re: [PATCH] arch/s390/perf: Register cpumf_pmu with type = PERF_TYPE_RAW

Mark Rutland
2024-03-04T09:34:07Z

On Mon, Mar 04, 2024 at 10:27:01AM +0800, JiaLong.Yang wrote:
> The struct pmu cpumf_pmu has handled generic events. So it need some
> flags to tell core this thing.

It's not necessary to register as PERF_TYPE_RAW in order to handle raw events,
and PERF_TYPE_RAW is not a flag.

Have you encountered a functional problem, or was this found by inspection?

Mark.

> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
> ---
> arch/s390/kernel/perf_cpum_cf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/perf_cpum_cf.c b/arch/s390/kernel/perf_cpum_cf.c
> index 41ed6e0f0a2a..6ba36cf50091 100644
> --- a/arch/s390/kernel/perf_cpum_cf.c
> +++ b/arch/s390/kernel/perf_cpum_cf.c
> @@ -1213,7 +1213,7 @@ static int __init cpumf_pmu_init(void)
> debug_register_view(cf_dbg, &debug_sprintf_view);
>
> cpumf_pmu.attr_groups = cpumf_cf_event_group();
> - rc = perf_pmu_register(&cpumf_pmu, "cpum_cf", -1);
> + rc = perf_pmu_register(&cpumf_pmu, "cpum_cf", PERF_TYPE_RAW);
> if (rc) {
> pr_err("Registering the cpum_cf PMU failed with rc=%i\n", rc);
> goto out2;
> --
> 2.25.1
>
>