From: Christoph Hellwig <hch@infradead.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Niklas Schnelle <schnelle@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Gerd Bayer <gbayer@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v3 2/3] vfio/pci: Tolerate oversized BARs by disallowing mmap
Date: Wed, 19 Jun 2024 00:11:52 -0700 [thread overview]
Message-ID: <ZnKEuCP7o6KurJvq@infradead.org> (raw)
In-Reply-To: <20240618095134.41478bbf.alex.williamson@redhat.com>
On Tue, Jun 18, 2024 at 09:51:34AM -0600, Alex Williamson wrote:
> > - if (!resource_size(res))
> > + if (!resource_size(res) ||
> > + resource_size(res) > (IOREMAP_END + 1 - IOREMAP_START))
> > goto no_mmap;
> >
> > if (resource_size(res) >= PAGE_SIZE) {
> >
>
> A powerpc build reports:
>
> ERROR: modpost: "__kernel_io_end" [drivers/vfio/pci/vfio-pci-core.ko] undefined!
>
> Looks like only __kernel_io_start is exported. Thanks,
And exported code has no business looking at either one.
I think the right thing here is a core PCI quirk to fix the BAR
size of the ISM device instead of this hack in vfio.
next prev parent reply other threads:[~2024-06-19 7:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 11:36 [PATCH v3 0/3] vfio/pci: s390: Fix issues preventing VFIO_PCI_MMAP=y for s390 and enable it Niklas Schnelle
2024-05-29 11:36 ` [PATCH v3 1/3] s390/pci: Fix s390_mmio_read/write syscall page fault handling Niklas Schnelle
2024-06-11 11:21 ` Niklas Schnelle
2024-06-11 12:08 ` Niklas Schnelle
2024-06-11 13:23 ` Niklas Schnelle
2024-06-11 14:13 ` David Hildenbrand
2024-06-11 14:47 ` Niklas Schnelle
2024-06-11 15:10 ` David Hildenbrand
2024-06-11 15:37 ` Niklas Schnelle
2024-06-11 22:21 ` Alex Williamson
2024-06-12 7:28 ` David Hildenbrand
2024-06-11 15:56 ` Niklas Schnelle
2024-05-29 11:36 ` [PATCH v3 2/3] vfio/pci: Tolerate oversized BARs by disallowing mmap Niklas Schnelle
2024-06-18 15:51 ` Alex Williamson
2024-06-19 7:11 ` Christoph Hellwig [this message]
2024-06-19 10:56 ` Niklas Schnelle
2024-06-20 4:09 ` Christoph Hellwig
2024-06-20 12:06 ` Niklas Schnelle
2024-06-20 12:29 ` Gerd Bayer
2024-05-29 11:36 ` [PATCH v3 3/3] vfio/pci: Enable PCI resource mmap() on s390 and remove VFIO_PCI_MMAP Niklas Schnelle
2024-06-18 15:52 ` Alex Williamson
2024-06-03 15:50 ` [PATCH v3 0/3] vfio/pci: s390: Fix issues preventing VFIO_PCI_MMAP=y for s390 and enable it Christian Borntraeger
2024-06-04 9:27 ` Niklas Schnelle
2024-06-05 7:49 ` Niklas Schnelle
2024-06-06 17:27 ` Alex Williamson
2024-06-07 7:38 ` Alexander Gordeev
2024-06-07 7:47 ` Niklas Schnelle
2024-06-07 14:23 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnKEuCP7o6KurJvq@infradead.org \
--to=hch@infradead.org \
--cc=agordeev@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=gbayer@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).