Re: [PATCH net-next v2 1/2] net/smc: introduce statistics for allocated ringbufs of link group

Wen Gu
2024-08-14T03:10:46Z

On 2024/8/13 22:40, Jakub Kicinski wrote:
> On Tue, 13 Aug 2024 17:55:17 +0800 Wen Gu wrote:
>> On 2024/8/13 08:41, Jakub Kicinski wrote:
>>> On Wed, 7 Aug 2024 15:59:38 +0800 Wen Gu wrote:
>>>> + if (nla_put_u64_64bit(skb, SMC_NLA_LGR_R_SNDBUF_ALLOC,
>>>> + lgr->alloc_sndbufs, SMC_NLA_LGR_R_PAD))
>>>
>>> nla_put_uint()
>>
>> Hi, Jakub. Thank you for reminder.
>>
>> I read the commit log and learned the advantages of this helper.
>> But it seems that the support for corresponding user-space helpers
>> hasn't kept up yet, e.g. can't find a helper like nla_get_uint in
>> latest libnl.
>
> Add it, then.

OK. So I guess we should use nla_put_uint for all 64bit cases from now on?