From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F0BA1AF0D3 for ; Tue, 19 Nov 2024 08:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732006379; cv=none; b=N6A3yKiceaw7Qab55B449+Qj0ZrBtrOK38B3KWkA8MF4Mnma58nUJ8PTQ1QybpBGuD65DdNBuByhgcfGVjpqcP8ARi6YspGHX1AxlFpDIwxpu3AePP0jVcBUhBBouJSa4x/OHVPNoDoTY/TpfHbgP3a6qcPpNXaVdeWHMRdEtUU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732006379; c=relaxed/simple; bh=1PQE1f1xCJGY7Tky1gUdhI5mXqSifmAXMo1KKarsrpI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uPYdYP2QseFInDpHjYtaBPV/xFWY8HGbrrK/X4CkWwv7ZTs4/nmAgvSiHQc3Ebp5IynLNNQlH7tyL/vc9DnUKDa86fw7ImGb8/xqzb2rhwixrFxdR6tFUZUiUnRQjvJpTP6i0jShPIiiFoXWW+iKLwZNvfPDC5aZf59prp6z3so= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=YwX88J07; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="YwX88J07" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4315df7b43fso5830905e9.0 for ; Tue, 19 Nov 2024 00:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732006375; x=1732611175; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=qaBG3Z7R9DOuiOybc185RSD4M8rIPEBBhrkZgjFmOxU=; b=YwX88J07/QkBNEkAjW82kPZVlFUMTCMLsjf6gwhsceK2l+pfQq+2IhMEYkPxcbHwhM iIQcYiE8dfVaomj+NhbmG33a7kOfZvnjheNotc1ehgHzsh9k5KiMvqplMIWd1Ktpn9J3 Jl0NwUBhIo15kB0LHJKNp3KvnQt5IzMLrmOUt5OqKtW5fSa8heyxjOg/WBK+TsNjc4QK 7m994E+mkEwkTIETkvQ3HV9EOmS6rF7kT/r6PvKAWOsvp3P9FDmpG8UYYfYu5j2pKTin nV23yVqo7cve/XHz6GfmTRniT88Dp7udY5CmrOUKjj10LxJKyDd7AoBmqCML/ASfnVOk i85A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732006375; x=1732611175; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qaBG3Z7R9DOuiOybc185RSD4M8rIPEBBhrkZgjFmOxU=; b=DXz0hbp6IBPqKK+Ie1hNJghsIXZDHfWhpKfAl9IufDgHUfJ7F0b5VvAYehdt18XFq3 XqVHXrGrvS7AeyCP6CzoQksMPNXxvWUALgZpaTBy5M7JMkjF5FtOMg20rUXw0iYgah4b nRzebkTFYe0EqNpt+jLBFHzMG2zuKUH7kSO3fEyI7e4imfp++OL1r6gDb2MZVFJiGY4e J6XTRPu/sTF7dOl6Pf85t3SGDOge2kqFo7qVOkdmocB+qlQGHYCyDRvdTkeXamzK1hsL l+MXdcrAEC8SbbrNTSuz1KLn6F68VrPb/exhh4jv67KgIzoxwgirJFHnbucWP4OZ349S utgg== X-Forwarded-Encrypted: i=1; AJvYcCVlYI95FB5DbNUAk0ObeK/fcSx0zjlqxIC90en4JJEdPckNN8qCm/ikNSwAE5v9N2A19ID225tTm2zP@vger.kernel.org X-Gm-Message-State: AOJu0YyC6/kaE6qcGL2Ry3JnoedP2YZXdgKLG7eUwxraDoetc5HRe9zp Tr60I1DphS9HDyfhRmfytag8UEFSydYdP3WKPzICiUKzdXLchSUtJuItOIzQzL0= X-Google-Smtp-Source: AGHT+IHrqP9nC2rPwknktgIKbjWoIt1yh0m5e2N0IUvcTBAuP3H8V/AdHOWp2OIw94YWQU//ijQi/A== X-Received: by 2002:a5d:6d0f:0:b0:382:2492:3218 with SMTP id ffacd0b85a97d-38225aaee39mr12773115f8f.47.1732006374705; Tue, 19 Nov 2024 00:52:54 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3824a8109a7sm3705943f8f.104.2024.11.19.00.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 00:52:54 -0800 (PST) Date: Tue, 19 Nov 2024 09:52:46 +0100 From: Petr Mladek To: Easwar Hariharan Cc: Christophe Leroy , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies() Message-ID: References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-19-911fb7595e79@linux.microsoft.com> <718febc4-59ee-4701-ad62-8b7a8fa7a910@csgroup.eu> <96f3b51b-c28c-4ea8-b61e-a4982196215f@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <96f3b51b-c28c-4ea8-b61e-a4982196215f@linux.microsoft.com> On Mon 2024-11-18 10:18:49, Easwar Hariharan wrote: > On 11/18/2024 3:06 AM, Petr Mladek wrote: > > On Sat 2024-11-16 11:10:52, Christophe Leroy wrote: > >> > >> > >> Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > >>> [Vous ne recevez pas souvent de courriers de eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > >>> > >>> Changes made with the following Coccinelle rules: > >>> > >>> @@ constant C; @@ > >>> > >>> - msecs_to_jiffies(C * 1000) > >>> + secs_to_jiffies(C) > >>> > >>> @@ constant C; @@ > >>> > >>> - msecs_to_jiffies(C * MSEC_PER_SEC) > >>> + secs_to_jiffies(C) > >>> > >>> Signed-off-by: Easwar Hariharan > >>> --- > >>> samples/livepatch/livepatch-callbacks-busymod.c | 2 +- > >>> samples/livepatch/livepatch-shadow-fix1.c | 2 +- > >>> samples/livepatch/livepatch-shadow-mod.c | 10 +++++----- > >>> 3 files changed, 7 insertions(+), 7 deletions(-) > >>> > >>> diff --git a/samples/livepatch/livepatch-callbacks-busymod.c b/samples/livepatch/livepatch-callbacks-busymod.c > >>> index 378e2d40271a9717d09eff51d3d3612c679736fc..d0fd801a7c21b7d7939c29d83f9d993badcc9aba 100644 > >>> --- a/samples/livepatch/livepatch-callbacks-busymod.c > >>> +++ b/samples/livepatch/livepatch-callbacks-busymod.c > >>> @@ -45,7 +45,7 @@ static int livepatch_callbacks_mod_init(void) > >>> { > >>> pr_info("%s\n", __func__); > >>> schedule_delayed_work(&work, > >>> - msecs_to_jiffies(1000 * 0)); > >>> + secs_to_jiffies(0)); > >> > >> Using secs_to_jiffies() is pointless, 0 is universal, should become > >> schedule_delayed_work(&work, 0); > > > > Yes, schedule_delayed_work(&work, 0) looks like the right solution. > > > > Or even better, it seems that the delayed work might get replaced by > > a normal workqueue work. > > > > Anyway, I am working on a patchset which would remove this sample > > module. There is no need to put much effort into the clean up > > of this particular module. Do whatever is easiest for you. > > > > Best Regards, > > Petr > > If we're removing the module, I'll drop it from the series. Just to > clarify, do you mean to remove all of samples/livepatch/* or some > particular file(s)? To be precise, I am going to replace: samples/livepatch/livepatch-callbacks-demo.c samples/livepatch/livepatch-callbacks-mod.c samples/livepatch/livepatch-callbacks-busymod.c with a completely different modules because I am reworking the callbacks API. All other sample modules are going to stay. Feel free to remove livepatch-callbacks-busymod.c from the patchset. But also feel free to keep it. The API rework goes slowly. I am not sure if it would be ready for 6.14. Best Regards, Petr