From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DD583FBEC4 for ; Wed, 8 Jul 2026 14:03:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783519426; cv=none; b=s64rMMhKdD5YCINnGNfVdlH5upJ4Memf/tq4kGy7q8Skqd50X/GKICFyumpvJtVX4nutysWwDtYO/dqyrUMy5X7aU04kGunr0pq7QsFlr/utxOpfIETyhtLGRhG6ifCF29H58I6vowVrf/ilUX7+9O7eWS/GJYVXvhPVnMJQ+dc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783519426; c=relaxed/simple; bh=4c3lCQF5RqYSquTuBnydxS2Q+5ojNMyJIO960AT3bfM=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=E5h9HkulxIriMIkWAyeo5RqGSZHCLB7PyEZhFgn5B/YF40brDRAPi2oTpV4j4uh83FJbb86ZXKdLaJq0b3WBm6kH4Ngf3xay9ibu02eENqTG4w2Xc71iYKwrIX+h3dszzA27A5J82sV8E49ZDXUVNgvyYEmBtGXT24jUGRxZNN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Y5frSsae; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Y5frSsae" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668CJFa72337005; Wed, 8 Jul 2026 14:03:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to; s=pp1; bh=I4IxKfqA01T+234O01+LQi8/m6ecoOkJixZfwnuqWyY=; b=Y5frSsaeMDfs bxZnbM2TxAP0U5hXI6rtxzyoYjx1ExifFopy6Ab91JTrCu5tGfOd+dLfTWuroPPJ yPyxjUIDvpz8O5+YZV0/q1Ed8PEvR+AkKCtDR74SwJxp4ZWFZ/sA4Yq07qY9TsD+ 9t0xN0ckZpaj1hJjEWJ8Gm84FW+GTNexktPIyoWxVlqiK6v8Xb0elg/Uh7rlHfWn QUmKCMMa17MDy7CN6r3Kv2Czy/hrM6tEIU1ayc0cfK30VgTFt1PNewaBdr8jh+uK gLzIpQcgi32OR3PCwcNEodlNlEcrVL+9g/kUzpyfEl1AxKErCEPvCpV8mUAXg4XI Y9KKwiyBTg== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6stsw2yr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jul 2026 14:03:15 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 668DnbcR005577; Wed, 8 Jul 2026 14:03:14 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4f7cvw8fac-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Jul 2026 14:03:14 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 668E3DIX58392902 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Jul 2026 14:03:13 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0161E5804B; Wed, 8 Jul 2026 14:03:13 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6078E58066; Wed, 8 Jul 2026 14:03:11 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 8 Jul 2026 14:03:11 +0000 (GMT) Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 08 Jul 2026 16:03:10 +0200 From: Harald Freudenberger To: Michael Tokarev Cc: richard.henderson@linaro.org, iii@linux.ibm.com, david@kernel.org, thuth@redhat.com, berrange@redhat.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org, linux-s390@vger.kernel.org, dengler@linux.ibm.com, borntraeger@linux.ibm.com, fcallies@linux.ibm.com, cohuck@redhat.com, qemu-stable , =?UTF-8?Q?Philippe_Mathieu-Daud?= =?UTF-8?Q?=C3=A9?= Subject: Re: [PATCH v11 01/21] target/s390x: Fix wrong address handling in address loops Reply-To: freude@linux.ibm.com Mail-Reply-To: freude@linux.ibm.com In-Reply-To: References: <20260707161815.40919-1-freude@linux.ibm.com> <20260707161815.40919-2-freude@linux.ibm.com> <3e31b38c-0561-4f37-b2c4-97c10e6f232f@tls.msk.ru> Message-ID: X-Sender: freude@linux.ibm.com Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: nS-CXDA6uRN6KE0nJe9hK-afP3wOClZO X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDEzNSBTYWx0ZWRfX7ShiCEucEmvr wSsD5W9PkGQzl+hOd6EHPNmgg24qTAM1OkBY4QQEoADe1wvQRmR1hkdH/p1nHEO+qbramthoJg3 /m2oKdoXw+HOjYTUJNNafENmmG3GGms= X-Authority-Analysis: v=2.4 cv=DKW/JSNb c=1 sm=1 tr=0 ts=6a4e58a3 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=jEcIRefS23jSGVE7dd0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: nS-CXDA6uRN6KE0nJe9hK-afP3wOClZO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDEzNSBTYWx0ZWRfX+v+q7Q3jnjTL O/zGQKu89ZTwR4J0xpyJIGFK5JTSlONx9CDgdKPQ9lzworChpkzqB6QHEb1Ap5xSJMkuNAL6Zyf 4mBmKNco6gwjfyu0ZSXc7bfh9CrF/RpUOOK+Fy7kyZqtzSWD6w6inYSMGZrXOfvoMTddf1lX0bm gDAflEX4i4KqIzuZ8GrPJ3gSj/Wj+lbP3kMhshPLUeir0Fl7dOHg2FM5dJV3lC3LQ4s7IsJGED0 MIcPFT7HLfaxAKF69NwDT+WW0QbnT1nHxtdhTSwkhVBnykDCxQE2+kzL8vQcwAJgRf+XrEpB3Dz yD6sSmCP8wHObu0k7iB+KxQm8/1Rwtf/FEl5wFDxjJxrWjuDEsRKbrL83ryAaPhn3bAS6fyH68g GVdFh6/pLbe1s3uCWzqTdTJ7Awfk/VWvfXKblTaaBVEGIZIqZoHGMltr+r+lzMWfu1JNZ9zTZ4i JKU5zrN5onjEF8QcTdA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_02,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 clxscore=1011 phishscore=0 impostorscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080135 On 2026-07-08 13:18, Michael Tokarev wrote: > On 08.07.2026 13:37, Michael Tokarev wrote: >> On 07.07.2026 19:17, Harald Freudenberger wrote: >>> The loop increments addr by the element stride (+= 4) before calling >>> wrap_address, but then overwrites the loop addr with the wrapped >>> value. On the next iteration the stride is applied to the wrapped >>> address of the previous element, not to the original unwrapped >>> address. This results in every element after the first is read from a >>> wrong (wrapped) address. >>> >>> Fixes: 9f17bfdab4 ("target/s390x: support SHA-512 extensions") >>> Signed-off-by: Harald Freudenberger >>> --- >>>   target/s390x/tcg/crypto_helper.c | 12 ++++-------- >>>   1 file changed, 4 insertions(+), 8 deletions(-) >> >> This feels like qemu-stable material. >> I'm picking this change up for currently active stable qemu series. >> Please let me know if I shouldn't. > > Um, this was a bit premature. > > This particular commit requires a previous commit in this area, > de96db79 "target/s390x: Compile crypto_helper.c as common unit". > It's easy to back-port across, but since this change ("Fix wrong > address handling...") hasn't been marked as for-stable, I'm *not* > doing that. If this change is actually needed in -stable, please > let me know. Also, is it okay to pick up the previous change > ("compile as common unit") to -stable too, to avoid fixing up > subsequent changes. > > Thanks, > > /mjt Fine with me. However, Connie replied to my v10 series that she wants to pick this patch. However, it is yet not on the qemu master branch.