Re: [kvm-unit-tests PATCH 2/6] s390x: uv-host: Add uninitialized UV tests

Steffen Eiden
2022-05-16T15:34:57Z

Hi Janosch,

On 5/16/22 17:15, Janosch Frank wrote:
> On 5/16/22 17:02, Steffen Eiden wrote:
>>
[snip]
> [...]
>>>    static void setup_vmem(void)
>>> @@ -514,6 +587,7 @@ int main(void)
>>>        test_priv();
>>>        test_invalid();
>>> +    test_uv_uninitialized();
>>>        test_query();
>>>        test_init();
>> IIRC this test must be done last, as a following test has an
>> uninitialized UV. Maybe add a short comment for that here.
>
> You're referring to the test_init()?
>
> The test_clear() function must be done last but you're commenting under
> the test_init() call. So I'm a bit confused about what you want me to do
> here.

Sorry, my fault. Yes I wanted to suggest a comment for the 'test_clear'
function.