Re: [kvm-unit-tests PATCH 5/6] s390x: uv-host: Add a set secure config parameters test function

Steffen Eiden
2022-05-17T11:33:05Z

Hey Janosch,

On 5/13/22 11:50, Janosch Frank wrote:
> Time for more tests.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Steffen Eiden <seiden@linux.ibm.com>
If you free 'pages'

> ---
> s390x/uv-host.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/s390x/uv-host.c b/s390x/uv-host.c
> index 153a94e1..20d805b8 100644
> --- a/s390x/uv-host.c
> +++ b/s390x/uv-host.c
> @@ -229,6 +229,52 @@ static void test_cpu_destroy(void)
> report_prefix_pop();
> }
>
> +static void test_set_se_header(void)
> +{
> + struct uv_cb_ssc uvcb = {
> + .header.cmd = UVC_CMD_SET_SEC_CONF_PARAMS,
> + .header.len = sizeof(uvcb),
> + .guest_handle = uvcb_cgc.guest_handle,
> + .sec_header_origin = 0,
> + .sec_header_len = 0x1000,
> + };
> + void *pages = alloc_pages(1);
> + void *inv;
> + int rc;
> +
> + report_prefix_push("sscp");
> +
> + uvcb.header.len -= 8;
> + rc = uv_call(0, (uint64_t)&uvcb);
> + report(rc == 1 && uvcb.header.rc == UVC_RC_INV_LEN,
> + "hdr invalid length");
> + uvcb.header.len += 8;
> +
> + uvcb.guest_handle += 1;
> + rc = uv_call(0, (uint64_t)&uvcb);
> + report(rc == 1 && uvcb.header.rc == UVC_RC_INV_GHANDLE, "invalid handle");
> + uvcb.guest_handle -= 1;
> +
> + inv = pages + PAGE_SIZE;
> + uvcb.sec_header_origin = (uint64_t)inv;
> + protect_page(inv, PAGE_ENTRY_I);
> + rc = uv_call(0, (uint64_t)&uvcb);
> + report(rc == 1 && uvcb.header.rc == 0x103,
> + "se hdr access exception");
> +
> + /*
> + * Shift the ptr so the first few DWORDs are accessible but
> + * the following are on an invalid page.
> + */
> + uvcb.sec_header_origin -= 0x20;
> + rc = uv_call(0, (uint64_t)&uvcb);
> + report(rc == 1 && uvcb.header.rc == 0x103,
> + "se hdr access exception crossing");
> + unprotect_page(inv, PAGE_ENTRY_I);

please free 'pages'.

> +
> + report_prefix_pop();
> +}
> +
> static void test_cpu_create(void)
> {
> int rc;
> @@ -669,6 +715,7 @@ int main(void)
>
> test_config_create();
> test_cpu_create();
> + test_set_se_header();
> test_cpu_destroy();
> test_config_destroy();
> test_clear();

Steffen