From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:55760 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726937AbgC3OAw (ORCPT ); Mon, 30 Mar 2020 10:00:52 -0400 Subject: Re: [kvm-unit-tests PATCH] s390x: Add stsi 3.2.2 tests References: <20200330122035.19607-1-frankja@linux.ibm.com> <727e1ed5-99ea-e559-ca9c-0f067cbcc153@linux.ibm.com> <2104b9a7-2ae0-6964-0eef-25ba7cca3119@linux.ibm.com> From: David Hildenbrand Message-ID: Date: Mon, 30 Mar 2020 16:00:42 +0200 MIME-Version: 1.0 In-Reply-To: <2104b9a7-2ae0-6964-0eef-25ba7cca3119@linux.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Janosch Frank , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, cohuck@redhat.com, borntraeger@de.ibm.com On 30.03.20 15:30, Janosch Frank wrote: > On 3/30/20 3:15 PM, David Hildenbrand wrote: >> On 30.03.20 15:09, Janosch Frank wrote: >>> On 3/30/20 3:03 PM, Janosch Frank wrote: >>>> On 3/30/20 2:50 PM, David Hildenbrand wrote: >>>>> On 30.03.20 14:20, Janosch Frank wrote: >>>>>> + report(data->vm[0].total_cpus == smp_query_num_cpus(), "cpu # total"); >>>>>> + report(data->vm[0].conf_cpus == smp_query_num_cpus(), "cpu # configured"); >>>>>> + report(data->vm[0].standby_cpus == 0, "cpu # standby"); >>>>>> + report(data->vm[0].reserved_cpus == 0, "cpu # reserved"); >>>>> >>>>> IIRC, using -smp 1,maxcpus=X, you could also test the reported reserved >>>>> CPUs. >>>> >>>> Will try that >>> >>> Just like I thought, QEMU does not manipulate cpu counts and KVM >>> pre-sets standby and reserved to 0. So we have absolutely no change when >>> adding the smp parameter. >> >> Well, for TCG it is properly implemented. Is this a BUG in KVM's STSI code? >> > > KVM tracks online cpus and created cpus, but only reports the online > ones in stsi. > Will QEMU register/create a reserved CPU with KVM? > > To fix this we could also fix-up the cpu reporting in QEMU after KVM > wrote its results. I think that would be preferred, and handling it similar to the TCG implementation > > @Christian: Guidance? > -- Thanks, David / dhildenb