Re: [PATCH v8 04/22] s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.

Tony Krowiak
2018-08-09T16:55:07Z

On 08/09/2018 11:43 AM, Heiko Carstens wrote:
> On Thu, Aug 09, 2018 at 11:18:05AM -0400, Tony Krowiak wrote:
>> On 08/09/2018 05:06 AM, Cornelia Huck wrote:
>>> On Wed, 8 Aug 2018 10:44:14 -0400
>>> Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote:
>>>
>>>> From: Harald Freudenberger <freude@de.ibm.com>
>>>>
>>>> Move all the inline functions from the ap bus header
>>>> file ap_asm.h into the in-kernel api header file
>>>> arch/s390/include/asm/ap.h so that KVM can make use
>>>> of all the low level AP functions.
>>>>
>>>> Signed-off-by: Harald Freudenberger <freude@de.ibm.com>
>>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> You should add your own s-o-b if you are sending on patches written by
>>> others (even if it does not matter in the end, when they are merged
>>> through a different path anyway.)
>> That's rather ironic given I was told in an internal review that I should
>> not sign off on patches I did not write.
> Please point the one who said that to
> Documentation/process/submitting-patches.rst / Developer's Certificate of Origin
>
> You really should sign off patches you forward, even if you did not write
> them on your own.

Duly noted and I will do so on future posts. Thanks for the reference.