Re: [RFC PATCH 05/12] fs/proc/task_mmu: refactor pagemap_pmd_range()

Lorenzo Stoakes
2025-10-27T15:27:36Z

On Fri, Oct 24, 2025 at 04:37:18PM -0400, Gregory Price wrote:
> On Fri, Oct 24, 2025 at 09:15:59PM +0100, Lorenzo Stoakes wrote:
> > On Fri, Oct 24, 2025 at 03:12:08PM -0400, Gregory Price wrote:
> >
> > So maybe actually that isn't too bad of an idea...
> >
> > Could also be
> >
> > nonpresent_or_swap_t but that's kinda icky...
>
> clearly we need:
>
> union {
> swp_entry_t swap;
> nonpresent_entry_t np;
> pony_entry_t pony;
> plum_emtry_t beer;
> } leaf_entry_t;
>
> with
>
> leaf_type whats_that_pte(leaf_entry_t);
>
> with 20 more new functions about how to manage leaf_entries ;]

:))))

Hm well the union is an amusing thought but more seriously leaf_entry_t
seems pretty good name-wise actually :)

>
> no not seriously, please have a good weekend!

Thanks :) Hope you had a good one too!

>
> and thanks again for doing this!

Thanks again :)

> ~Gregory

Cheers, Lorenzo