From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 779B9329E62 for ; Wed, 5 Nov 2025 14:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762353751; cv=none; b=SlrA07h/JTOCeBf+xGVdR3/Z665UeArnynxwd82/1mBCSC2Dy0rNjsl5OZCC73XrE8NKgp+E4l3UKlygEFADJMOxd8aW4yz3y9J5HB4EeyWAadUZECH9ecq3uUNoUv/w5fBI7DLMoORRSiluq3Ss82cUudluSxcXxcNLe3WLypE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762353751; c=relaxed/simple; bh=ij2iHrslX/5yNAV81WvwyiP5ZRrrhcDqQSgtHEa9ZoY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rrobb3pDFGpIjxtRmqqUZrYscLHFGtr5w2XuNgpA42b8PtJXhnxaDgSUJD5NMVvhh67YysERw1FEUpWgDtubLdCKVF6hxZEaEkNyf1udN8cPoAzx8hxeTyJ4deGmS4ovHMt8zoc8TSaLCfxHE/Pg+XQKUMpic2Z73f6j/CX65HY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=gCDf5z05; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="gCDf5z05" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-8b22624bcdaso96506785a.3 for ; Wed, 05 Nov 2025 06:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1762353748; x=1762958548; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gCP0hsq/q40gFxNmjoVFcp0QbOx89aTWebuusBQgCaY=; b=gCDf5z05uYtlJggKnF95ezS3J3umvz7sQMNDZDnGK8dtKLvayu7kdaLUtT1vMZ6cHs 1GrwbtfIe7scOFlP2tQeblKFtqfnBbDDvWuaerJCvF4fbX4Iuw1jMMO5qNBS6ZY5ORf7 wlXA8FlARkhwl3/zBiBwJU4aOeCxfoymxp+HA7s9/gBrOxzS0LNRs3+Mbv6zW6wrbKgS Vw1NtjBOiZPKJ476QYp/x9lkuvghR476RYKYUJr6/ygsD+kVyEil9ToZF0qbl82FpAPl jncikulGE0TeNC1J/5fCUZfNhIKnf6FldJa+Hdi7S90irvpaNARjjyogJGnYymejeFSJ J/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762353748; x=1762958548; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gCP0hsq/q40gFxNmjoVFcp0QbOx89aTWebuusBQgCaY=; b=bKGiCxOfZTHYVgIYlODXc5Zso0yGMZfV6ZjdS7imTjeJnWhK6MyFKb2Mx8ea3cIxLw 2qyRpYMqjw3wBFDB14ApaAKjzMkj7U44Abx/YKU/Y/Lc0I55aapXQ2q/CRgqPT0Y7PIe uOfJJ1dPDslAqfTE8ZKHtgTpvn3yIp/OrSMHFycKwvWXmcxpDs/4+SoqfylNWNDlh8d2 Azn/hV/IgNuQxvjGxzZv5KIt5fNOnaJe1c8wHW+BWtObs94R0/WQs+soqkC/9NJTGsJY E+WZELtWoSUn2LNJV44z7zDp1JKx1TIUnXbsU10e7mz2M976S2tdpP/DNKHOYjFccAIi ClRg== X-Forwarded-Encrypted: i=1; AJvYcCUbSrusyDUOrXx3HuoY1CM0l9qvO+ExVcxPFRrJyJNq8IScGdg9nsxMmiSSBVL5J6ZpFb89ZyP5fAJM@vger.kernel.org X-Gm-Message-State: AOJu0Yw55EUfbwLRpgu4ALr95bvahY++36eSLYXeqakBkQyh8YblN2QC qWvt+Ko8C43QJm2tUz83aA3BjfhKvKnaY2+5v1d99um6mv7aw4DKioEkGdYDsIg4ZCk= X-Gm-Gg: ASbGncsDLqbODX71ZctFoBCubrsm0mW/nsDd5yzn8W0NttvRgYvjCvwLvMwV0Q8t1Ap DX9Pkr5RcDKVswi1tRdRn6JXsN/3DAVvH0IOJxyAY49DbvUg2ZR6qC7PddoGZnlROfhMpU6BP8u yPxDtw1GHXq3iO1cvp1GkJs4IMVTuTrZcI4xiS0Z/WMb+X+ceL4tLNi8WlqVNxem00LII/tC6z5 FwP05fEd9nSa/7zp9mZAX/Y9XIRL4PqBphSdTc/jjv2NQKqxLyHR2TxSrNJ8kni8lCC0Frxe8M9 nMoyKt5JqqlQp8k1GPm+xgPP84fiJt2JV1CsPY6se1uIpe4ATSl7DyMs7OstX/16A5YW4Zek+4J Le9RR6L7hWUOTaPFz9vnHn7eN1v8QoX5TrzEgUpxqfiNiWUIrKIo+ffyh7FbSd/1D4ZU6e47scy 3q4d/NL2lEr0eUt9QjJH1hc8ETN2GFHsWM1oh8GfUpBJcDlfokUtOVHqMTY59DiE9lR4BiNA== X-Google-Smtp-Source: AGHT+IFOPmymxkVWTStAmI1fSxsEHrX8n+cH3NR2hrKHNMeSwi6zTbwFsDY5mjtR5/Zbzi6pU1fUXg== X-Received: by 2002:a05:620a:4416:b0:8ab:4ada:9b2f with SMTP id af79cd13be357-8b220b7f441mr375892585a.56.1762353748298; Wed, 05 Nov 2025 06:42:28 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b21fc36dbasm239867985a.19.2025.11.05.06.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Nov 2025 06:42:27 -0800 (PST) Date: Wed, 5 Nov 2025 09:42:24 -0500 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Sven Schnelle , Peter Xu , Alexander Viro , Christian Brauner , Jan Kara , Arnd Bergmann , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Muchun Song , Oscar Salvador , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Axel Rasmussen , Yuanchu Xie , Wei Xu , Kemeng Shi , Kairui Song , Nhat Pham , Baoquan He , Chris Li , SeongJae Park , Matthew Wilcox , Jason Gunthorpe , Leon Romanovsky , Xu Xin , Chengming Zhou , Jann Horn , Miaohe Lin , Naoya Horiguchi , Pedro Falcato , Pasha Tatashin , Rik van Riel , Harry Yoo , Hugh Dickins , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 02/16] mm: introduce leaf entry type and use to simplify leaf entry logic Message-ID: References: <2c75a316f1b91a502fad718de9b1bb151aafe717.1762171281.git.lorenzo.stoakes@oracle.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c75a316f1b91a502fad718de9b1bb151aafe717.1762171281.git.lorenzo.stoakes@oracle.com> On Mon, Nov 03, 2025 at 12:31:43PM +0000, Lorenzo Stoakes wrote: > +typedef swp_entry_t leaf_entry_t; > + > +#ifdef CONFIG_MMU > + > +/* Temporary until swp_entry_t eliminated. */ > +#define LEAF_TYPE_SHIFT SWP_TYPE_SHIFT > + > +enum leaf_entry_type { > + /* Fundamental types. */ > + LEAFENT_NONE, > + LEAFENT_SWAP, > + /* Migration types. */ > + LEAFENT_MIGRATION_READ, > + LEAFENT_MIGRATION_READ_EXCLUSIVE, > + LEAFENT_MIGRATION_WRITE, > + /* Device types. */ > + LEAFENT_DEVICE_PRIVATE_READ, > + LEAFENT_DEVICE_PRIVATE_WRITE, > + LEAFENT_DEVICE_EXCLUSIVE, > + /* H/W posion types. */ > + LEAFENT_HWPOISON, > + /* Marker types. */ > + LEAFENT_MARKER, > +}; > + Have been browsing the patch set again, will get around a deeper review, but just wanted to say this is a thing of beauty :] ~Gregory