Re: [RFC 08/10] KVM: s390: Use gpa_t in priv.c

[Janosch Frank <frankja@linux.ibm.com>]

On 3/18/26 17:02, Claudio Imbrenda wrote:
> On Mon, 16 Mar 2026 16:23:55 +0000
> Janosch Frank <frankja@linux.ibm.com> wrote:
> 
>> More unsigned long to gpa_t conversions.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>>   arch/s390/kvm/gaccess.h |  8 ++++++++
>>   arch/s390/kvm/priv.c    | 27 ++++++++++++---------------
>>   2 files changed, 20 insertions(+), 15 deletions(-)
>>
>> diff --git a/arch/s390/kvm/gaccess.h b/arch/s390/kvm/gaccess.h
>> index f23dc0729649..970d9020dc14 100644
>> --- a/arch/s390/kvm/gaccess.h
>> +++ b/arch/s390/kvm/gaccess.h
>> @@ -89,6 +89,14 @@ static inline unsigned long kvm_s390_logical_to_effective(struct kvm_vcpu *vcpu,
>>   	return _kvm_s390_logical_to_effective(&vcpu->arch.sie_block->gpsw, ga);
>>   }
>>   
>> +static inline gpa_t kvm_s390_real_to_abs_effective(struct kvm_vcpu *vcpu,
>> +						   unsigned long gra)
> 
> the name is confusing, it should be something more like
> kvm_logical_to_abs, or kvm_logical_effective_to_abs
Since logical can be virtual, I don't think these suggestions fit the 
bill. It works for logical to effective since that's about address size. 
Logical is a catch-all and so is effective.