public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] perf test: Run test 126 exclusive
@ 2026-04-08 11:31 Thomas Richter
  2026-04-09  2:31 ` Namhyung Kim
  2026-04-09 16:46 ` Namhyung Kim
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Richter @ 2026-04-08 11:31 UTC (permalink / raw)
  To: linux-kernel, linux-s390, linux-perf-users, acme, namhyung,
	irogers, howardchu95
  Cc: agordeev, gor, sumanthk, hca, japo, Thomas Richter

V1 --> V2 Fixed commit message

Running both tests cases 126 128 together causes the first test case
126 to fail:
 # for i in $(seq 3); do ./perf test 126 128; done
 126: perf trace BTF general tests    : FAILED!
 128: perf trace record and replay    : Ok
 126: perf trace BTF general tests    : FAILED!
 128: perf trace record and replay    : Ok
 126: perf trace BTF general tests    : FAILED!
 128: perf trace record and replay    : Ok
 #

Test case 126 fails because test case 128 runs concurrently as can
be observed using a ps -ef | grep perf output list on a different
window. Both do a perf trace command concurrently.
Make test case 'perf trace BTF general tests' exclusive.

Output after:
 # for i in $(seq 3); do ./perf test 'perf trace BTF general tests' \
	'perf trace record and replay'; done
 127: perf trace BTF general tests                   : Ok
 155: perf trace record and replay                   : Ok
 127: perf trace BTF general tests                   : Ok
 155: perf trace record and replay                   : Ok
 127: perf trace BTF general tests                   : Ok
 155: perf trace record and replay                   : Ok
 #

Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Cc: Howard Chu <howardchu95@gmail.com>
---
 tools/perf/tests/shell/trace_btf_general.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests/shell/trace_btf_general.sh
index ef2da806be6b..7a94a5743924 100755
--- a/tools/perf/tests/shell/trace_btf_general.sh
+++ b/tools/perf/tests/shell/trace_btf_general.sh
@@ -1,5 +1,5 @@
 #!/bin/bash
-# perf trace BTF general tests
+# perf trace BTF general tests (exclusive)
 # SPDX-License-Identifier: GPL-2.0
 
 err=0
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] perf test: Run test 126 exclusive
  2026-04-08 11:31 [PATCH v2] perf test: Run test 126 exclusive Thomas Richter
@ 2026-04-09  2:31 ` Namhyung Kim
  2026-04-09  2:44   ` Howard Chu
  2026-04-09 16:46 ` Namhyung Kim
  1 sibling, 1 reply; 4+ messages in thread
From: Namhyung Kim @ 2026-04-09  2:31 UTC (permalink / raw)
  To: Thomas Richter
  Cc: linux-kernel, linux-s390, linux-perf-users, acme, irogers,
	howardchu95, agordeev, gor, sumanthk, hca, japo

On Wed, Apr 08, 2026 at 01:31:43PM +0200, Thomas Richter wrote:
> V1 --> V2 Fixed commit message
> 
> Running both tests cases 126 128 together causes the first test case
> 126 to fail:
>  # for i in $(seq 3); do ./perf test 126 128; done
>  126: perf trace BTF general tests    : FAILED!
>  128: perf trace record and replay    : Ok
>  126: perf trace BTF general tests    : FAILED!
>  128: perf trace record and replay    : Ok
>  126: perf trace BTF general tests    : FAILED!
>  128: perf trace record and replay    : Ok
>  #

The test numbers can be different on other platforms, let's use the test
names like below.

> 
> Test case 126 fails because test case 128 runs concurrently as can
> be observed using a ps -ef | grep perf output list on a different
> window. Both do a perf trace command concurrently.
> Make test case 'perf trace BTF general tests' exclusive.
> 
> Output after:
>  # for i in $(seq 3); do ./perf test 'perf trace BTF general tests' \
> 	'perf trace record and replay'; done
>  127: perf trace BTF general tests                   : Ok
>  155: perf trace record and replay                   : Ok
>  127: perf trace BTF general tests                   : Ok
>  155: perf trace record and replay                   : Ok
>  127: perf trace BTF general tests                   : Ok
>  155: perf trace record and replay                   : Ok
>  #

I believe I have a fix for this problem but it's blocked by a BPF
verifier issue.  I need to find time to work on it again..

https://lore.kernel.org/linux-perf-users/20250814071754.193265-1-namhyung@kernel.org/

Until then, I think it's ok to have this.

Thanks,
Namhyung

> 
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> Cc: Howard Chu <howardchu95@gmail.com>
> ---
>  tools/perf/tests/shell/trace_btf_general.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests/shell/trace_btf_general.sh
> index ef2da806be6b..7a94a5743924 100755
> --- a/tools/perf/tests/shell/trace_btf_general.sh
> +++ b/tools/perf/tests/shell/trace_btf_general.sh
> @@ -1,5 +1,5 @@
>  #!/bin/bash
> -# perf trace BTF general tests
> +# perf trace BTF general tests (exclusive)
>  # SPDX-License-Identifier: GPL-2.0
>  
>  err=0
> -- 
> 2.53.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] perf test: Run test 126 exclusive
  2026-04-09  2:31 ` Namhyung Kim
@ 2026-04-09  2:44   ` Howard Chu
  0 siblings, 0 replies; 4+ messages in thread
From: Howard Chu @ 2026-04-09  2:44 UTC (permalink / raw)
  To: Namhyung Kim
  Cc: Thomas Richter, linux-kernel, linux-s390, linux-perf-users, acme,
	irogers, agordeev, gor, sumanthk, hca, japo

Hi Namhyung and Thomas,

On Wed, Apr 8, 2026 at 7:31 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> On Wed, Apr 08, 2026 at 01:31:43PM +0200, Thomas Richter wrote:
> > V1 --> V2 Fixed commit message
> >
> > Running both tests cases 126 128 together causes the first test case
> > 126 to fail:
> >  # for i in $(seq 3); do ./perf test 126 128; done
> >  126: perf trace BTF general tests    : FAILED!
> >  128: perf trace record and replay    : Ok
> >  126: perf trace BTF general tests    : FAILED!
> >  128: perf trace record and replay    : Ok
> >  126: perf trace BTF general tests    : FAILED!
> >  128: perf trace record and replay    : Ok
> >  #
>
> The test numbers can be different on other platforms, let's use the test
> names like below.
>
> >
> > Test case 126 fails because test case 128 runs concurrently as can
> > be observed using a ps -ef | grep perf output list on a different
> > window. Both do a perf trace command concurrently.
> > Make test case 'perf trace BTF general tests' exclusive.
> >
> > Output after:
> >  # for i in $(seq 3); do ./perf test 'perf trace BTF general tests' \
> >       'perf trace record and replay'; done
> >  127: perf trace BTF general tests                   : Ok
> >  155: perf trace record and replay                   : Ok
> >  127: perf trace BTF general tests                   : Ok
> >  155: perf trace record and replay                   : Ok
> >  127: perf trace BTF general tests                   : Ok
> >  155: perf trace record and replay                   : Ok
> >  #
>
> I believe I have a fix for this problem but it's blocked by a BPF
> verifier issue.  I need to find time to work on it again..
>
> https://lore.kernel.org/linux-perf-users/20250814071754.193265-1-namhyung@kernel.org/
>
> Until then, I think it's ok to have this.

Agreed.

Thanks,
Howard

>
> Thanks,
> Namhyung
>
> >
> > Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> > Cc: Howard Chu <howardchu95@gmail.com>

Acked-by: Howard Chu <howardchu95@gmail.com>

Thanks,
Howard

> > ---
> >  tools/perf/tests/shell/trace_btf_general.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/shell/trace_btf_general.sh b/tools/perf/tests/shell/trace_btf_general.sh
> > index ef2da806be6b..7a94a5743924 100755
> > --- a/tools/perf/tests/shell/trace_btf_general.sh
> > +++ b/tools/perf/tests/shell/trace_btf_general.sh
> > @@ -1,5 +1,5 @@
> >  #!/bin/bash
> > -# perf trace BTF general tests
> > +# perf trace BTF general tests (exclusive)
> >  # SPDX-License-Identifier: GPL-2.0
> >
> >  err=0
> > --
> > 2.53.0
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] perf test: Run test 126 exclusive
  2026-04-08 11:31 [PATCH v2] perf test: Run test 126 exclusive Thomas Richter
  2026-04-09  2:31 ` Namhyung Kim
@ 2026-04-09 16:46 ` Namhyung Kim
  1 sibling, 0 replies; 4+ messages in thread
From: Namhyung Kim @ 2026-04-09 16:46 UTC (permalink / raw)
  To: linux-kernel, linux-s390, linux-perf-users, acme, irogers,
	howardchu95, Thomas Richter
  Cc: agordeev, gor, sumanthk, hca, japo

On Wed, 08 Apr 2026 13:31:43 +0200, Thomas Richter wrote:
> V1 --> V2 Fixed commit message
> 
> Running both tests cases 126 128 together causes the first test case
> 126 to fail:
>  # for i in $(seq 3); do ./perf test 126 128; done
>  126: perf trace BTF general tests    : FAILED!
>  128: perf trace record and replay    : Ok
>  126: perf trace BTF general tests    : FAILED!
>  128: perf trace record and replay    : Ok
>  126: perf trace BTF general tests    : FAILED!
>  128: perf trace record and replay    : Ok
>  #
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-04-09 16:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-08 11:31 [PATCH v2] perf test: Run test 126 exclusive Thomas Richter
2026-04-09  2:31 ` Namhyung Kim
2026-04-09  2:44   ` Howard Chu
2026-04-09 16:46 ` Namhyung Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox