Re: [v3] s390/pkey: Use memdup_user() rather than duplicating its implementation

Christian Borntraeger
2019-11-11T08:27:55Z

On 11.11.19 09:11, Markus Elfring wrote:
>>> From: Markus Elfring <elfring@users.sourceforge.net>
>>> Date: Fri, 8 Nov 2019 17:50:22 +0100
> …
>>> Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support")
>>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>>
>> You were sending this from a different email address.
>
> Yes.
>
>
>> Can you use the same for the sender and the signoff?
>
> I would prefer to use the other email address (for a while).

The signoff is there to track the patch flow so I prefer that both
addresses match.

>> Can you also change the subject to indicate the "fix". e.g. something like
>>
>> s390/pkey: fix memory leak in error case by using memdup_user() rather than open coding
>
> Does this change request indicate also a need to split the software update
> between the discussed two function implementations?

No, I just want to have the word "fix" in the subject.

If you are OK with changing the sign-off to your web.de address
I can do both changes when applying.

You can answer with
Signed-off-by: <your web.de address>

as approval.