Re: [PATCH v2 04/15] KVM: s390: fake memslot for ucontrol VMs

Claudio Imbrenda
2025-01-16T12:46:28Z

On Thu, 16 Jan 2025 13:42:50 +0100
Janosch Frank <frankja@linux.ibm.com> wrote:

> On 1/16/25 12:33 PM, Claudio Imbrenda wrote:
> > Create a fake memslot for ucontrol VMs. The fake memslot identity-maps
> > userspace.
> >
> > Now memslots will always be present, and ucontrol is not a special case
> > anymore.
> >
> > Suggested-by: Sean Christopherson <seanjc@google.com>
> > Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
>
> You'll need to update the Documentation because of the ucontrol
> EINVAL/EEXIST return change.

ufff that fell off my brain cache; I'll fix it

>
> I don't like having EEXIST as a return value but I also don't see a lot
> of gains in changing common code just so we can return the correct rc.