From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A5D9C433EF for ; Wed, 20 Oct 2021 10:31:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39351610FF for ; Wed, 20 Oct 2021 10:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbhJTKdn (ORCPT ); Wed, 20 Oct 2021 06:33:43 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:15562 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229639AbhJTKdl (ORCPT ); Wed, 20 Oct 2021 06:33:41 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19K9g6kF027718; Wed, 20 Oct 2021 06:31:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=4TNPqJ6VRSZjFmWEKIqH4GNmCkPkeDUqdLzbHULq/X4=; b=PleRByEDF/oObRruS/t1TxEc2Ny+ZVtOe/rIVVp/i4aIizYtiQR1+XRayn1VAjfd5Fcc OVHdFdiIyranPsSBzpJOAyHqwtQh6O5yH/fMlcuRoX+jbUkGZJa1NFmxP4j2B8om9+vc 0xi9jzqnus5uea94tKG8XpuvfZ5tVOSq207USwfF+5N4Si5YJCfb7f4ygWgDCJ5OclSx kdikscsc390TwMUuhN8VL7Ph5kQMPtr1HoA9o7/OLu00UnrPKgydESWdiUa0d/2pwijC inoPpKMfkelOeXcDMCGTzX3KOlwyG8e1ez+Y9x9JWVU3GR8DjLpRtyPU2z/hB/6Hw5rC +w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3btgq50wx5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Oct 2021 06:31:26 -0400 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 19KAFGkH008742; Wed, 20 Oct 2021 06:31:26 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 3btgq50wwk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Oct 2021 06:31:26 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 19KAK20r021442; Wed, 20 Oct 2021 10:31:24 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma03ams.nl.ibm.com with ESMTP id 3bqpca3dat-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Oct 2021 10:31:24 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 19KAVKGA57934334 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Oct 2021 10:31:21 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DC1F552076; Wed, 20 Oct 2021 10:31:20 +0000 (GMT) Received: from li-43c5434c-23b8-11b2-a85c-c4958fb47a68.ibm.com (unknown [9.171.54.36]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 2A56A52079; Wed, 20 Oct 2021 10:31:20 +0000 (GMT) Subject: Re: [PATCH 3/3] KVM: s390: clear kicked_mask if not idle after set To: Michael Mueller , Halil Pasic , Janosch Frank , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Pierre Morel , Tony Krowiak , Matthew Rosato , Niklas Schnelle , farman@linux.ibm.com, kvm@vger.kernel.org References: <20211019175401.3757927-1-pasic@linux.ibm.com> <20211019175401.3757927-4-pasic@linux.ibm.com> <8cb919e7-e7ab-5ec1-591e-43f95f140d7b@linux.ibm.com> From: Christian Borntraeger Message-ID: Date: Wed, 20 Oct 2021 12:31:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <8cb919e7-e7ab-5ec1-591e-43f95f140d7b@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: PS0tvRsx8nykzxHtCNIes5N2TRNcWDNM X-Proofpoint-GUID: Qa8BskqlI9ce_xAcwnVDMNU4N36MLHw9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-20_04,2021-10-20_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 adultscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 spamscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110200060 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org Am 20.10.21 um 11:48 schrieb Michael Mueller: > > > On 19.10.21 19:54, Halil Pasic wrote: >> The idea behind kicked mask is that we should not re-kick a vcpu >> from __airqs_kick_single_vcpu() that is already in the middle of >> being kicked by the same function. >> >> If however the vcpu that was idle before when the idle_mask was >> examined, is not idle any more after the kicked_mask is set, that >> means that we don't need to kick, and that we need to clear the >> bit we just set because we may be beyond the point where it would >> get cleared in the wake-up process. Since the time window is short, >> this is probably more a theoretical than a practical thing: the race >> window is small. >> >> To get things harmonized let us also move the clear from vcpu_pre_run() >> to __unset_cpu_idle(). >> >> Signed-off-by: Halil Pasic >> Fixes: 9f30f6216378 ("KVM: s390: add gib_alert_irq_handler()") > > Before releasing something like this, where none of us is sure if > it really saves cpu cost, I'd prefer to run some measurement with > the whole kicked_mask logic removed and to compare the number of > vcpu wake ups with the number of interrupts to be processed by > the gib alert mechanism in a slightly over committed host while > driving with Matthews test load. But I think patch 1 and 2 can go immediately as they measurably or testable fix things. Correct? > A similar run can be done with this code. > >> --- >>   arch/s390/kvm/interrupt.c | 7 ++++++- >>   arch/s390/kvm/kvm-s390.c  | 2 -- >>   2 files changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c >> index 2245f4b8d362..3c80a2237ef5 100644 >> --- a/arch/s390/kvm/interrupt.c >> +++ b/arch/s390/kvm/interrupt.c >> @@ -426,6 +426,7 @@ static void __unset_cpu_idle(struct kvm_vcpu *vcpu) >>   { >>       kvm_s390_clear_cpuflags(vcpu, CPUSTAT_WAIT); >>       clear_bit(vcpu->vcpu_idx, vcpu->kvm->arch.idle_mask); >> +    clear_bit(vcpu->vcpu_idx, vcpu->kvm->arch.gisa_int.kicked_mask); >>   } >>   static void __reset_intercept_indicators(struct kvm_vcpu *vcpu) >> @@ -3064,7 +3065,11 @@ static void __airqs_kick_single_vcpu(struct kvm *kvm, u8 deliverable_mask) >>               /* lately kicked but not yet running */ >>               if (test_and_set_bit(vcpu_idx, gi->kicked_mask)) >>                   return; >> -            kvm_s390_vcpu_wakeup(vcpu); >> +            /* if meanwhile not idle: clear  and don't kick */ >> +            if (test_bit(vcpu_idx, kvm->arch.idle_mask)) >> +                kvm_s390_vcpu_wakeup(vcpu); >> +            else >> +                clear_bit(vcpu_idx, gi->kicked_mask); >>               return; >>           } >>       } >> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c >> index 1c97493d21e1..6b779ef9f5fb 100644 >> --- a/arch/s390/kvm/kvm-s390.c >> +++ b/arch/s390/kvm/kvm-s390.c >> @@ -4067,8 +4067,6 @@ static int vcpu_pre_run(struct kvm_vcpu *vcpu) >>           kvm_s390_patch_guest_per_regs(vcpu); >>       } >> -    clear_bit(vcpu->vcpu_idx, vcpu->kvm->arch.gisa_int.kicked_mask); >> - >>       vcpu->arch.sie_block->icptcode = 0; >>       cpuflags = atomic_read(&vcpu->arch.sie_block->cpuflags); >>       VCPU_EVENT(vcpu, 6, "entering sie flags %x", cpuflags); >>