Re: [PATCH] s390/cio: add missing MODULE_DESCRIPTION() macros

Vineeth Vijayan
2024-06-18T12:52:38Z

On 6/16/24 05:56, Jeff Johnson wrote:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/ccwgroup.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/cio/vfio_ccw.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/s390/cio/ccwgroup.c | 1 +
> drivers/s390/cio/vfio_ccw_drv.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
> index b72f672a7720..a741e5012fce 100644
> --- a/drivers/s390/cio/ccwgroup.c
> +++ b/drivers/s390/cio/ccwgroup.c
> @@ -550,4 +550,5 @@ void ccwgroup_remove_ccwdev(struct ccw_device *cdev)
> put_device(&gdev->dev);
> }
> EXPORT_SYMBOL(ccwgroup_remove_ccwdev);
> +MODULE_DESCRIPTION("CCW group bus driver");

the name of the bus here is "ccwgroup" bus without a space.
Otherwise this change in ccwgroup.c looks good to me.
Thank you for the patch.

With the correction mentioned above,
Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com>

> MODULE_LICENSE("GPL");
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 8ad49030a7bf..49da348355b4 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -488,4 +488,5 @@ static void __exit vfio_ccw_sch_exit(void)
> module_init(vfio_ccw_sch_init);
> module_exit(vfio_ccw_sch_exit);
>
> +MODULE_DESCRIPTION("VFIO based Physical Subchannel device driver");

Halil/Mathew/Eric,
Could you please comment on this ?

> MODULE_LICENSE("GPL v2");
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240615-md-s390-drivers-s390-cio-3598abb802ad
>