From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 29 Jun 2014 00:18:18 +0100 (BST) From: "Maciej W. Rozycki" Subject: [PATCH] sched.h: Remove useless `const' from function return type Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Vincent Guittot Cc: Dietmar Eggemann , Preeti U Murthy Dietmar Eggemann , Peter Zijlstra , Andrew Morton , Benjamin Herrenschmidt , Bjorn Helgaas , Chris Metcalf , Christoph Lameter , "David S. Miller" , Fenghua Yu , Greg Kroah-Hartman , Hanjun Guo , Heiko Carstens , Jason Low , Linus Torvalds , Martin Schwidefsky , Tony Luck , linux390@de.ibm.com, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, Ingo Molnar , linux-kernel@vger.kernel.org List-ID: This fixes: cc1: warnings being treated as errors In file included from include/linux/ptrace.h:5, from arch/mips/kernel/cpu-probe.c:16: include/linux/sched.h:1002: warning: type qualifiers ignored on function return type make[2]: *** [arch/mips/kernel/cpu-probe.o] Error 1 This is a regression introduced with commit 143e1e28cb40bed836b0a06567208bd7347c9672 [sched: Rework sched_domain topology definition]. The warning itself is benign except in places like the arch/mips subtree where we use `-Werror' to enforce good coding practices. Apparently the warning is GCC-version specific, some versions produce it and some do not. Signed-off-by: Maciej W. Rozycki --- Vincent, Did you mean: typedef int __attribute__((const)) (*sched_domain_flags_f)(void); by any chance? Maciej linux-sched-domain-flags-type.patch Index: linux-20140623-swarm64/include/linux/sched.h =================================================================== --- linux-20140623-swarm64.orig/include/linux/sched.h +++ linux-20140623-swarm64/include/linux/sched.h @@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t do bool cpus_share_cache(int this_cpu, int that_cpu); typedef const struct cpumask *(*sched_domain_mask_f)(int cpu); -typedef const int (*sched_domain_flags_f)(void); +typedef int (*sched_domain_flags_f)(void); #define SDTL_OVERLAP 0x01