Re: [PATCH] s390: qdio: Convert timers to use timer_setup()

Kees Cook
2017-10-05T16:58:55Z

On Thu, Oct 5, 2017 at 2:13 AM, Sebastian Ott <sebott@linux.vnet.ibm.com> wrote:
> On Wed, 4 Oct 2017, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicitly.
>
>> -void qdio_outbound_timer(unsigned long data)
>> +void qdio_outbound_timer(struct timer_list *t)
>> {
>> - struct qdio_q *q = (struct qdio_q *)data;
>> + struct qdio_q *q = from_timer(q, t, o.out.timer);
> ^
> this should be u.out.timer

Oh thank you, good catch!

> Will be applied to s390/linux.git

Did you fix this up already or should I send a v2?

-Kees

--
Kees Cook
Pixel Security