Re: [PATCH 05/10] s390/cio: introduce DMA pools to cio

Cornelia Huck
2019-05-10T14:10:13Z

On Fri, 10 May 2019 00:11:12 +0200
Halil Pasic <pasic@linux.ibm.com> wrote:

> On Thu, 9 May 2019 12:11:06 +0200
> Cornelia Huck <cohuck@redhat.com> wrote:
>
> > On Wed, 8 May 2019 23:22:10 +0200
> > Halil Pasic <pasic@linux.ibm.com> wrote:
> >
> > > On Wed, 8 May 2019 15:18:10 +0200 (CEST)
> > > Sebastian Ott <sebott@linux.ibm.com> wrote:
> >
> > > > > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void)
> > > > > unregister_reboot_notifier(&css_reboot_notifier);
> > > > > goto out_unregister;
> > > > > }
> > > > > + cio_dma_pool_init();
> > > >
> > > > This is too late for early devices (ccw console!).
> > >
> > > You have already raised concern about this last time (thanks). I think,
> > > I've addressed this issue: tje cio_dma_pool is only used by the airq
> > > stuff. I don't think the ccw console needs it. Please have an other look
> > > at patch #6, and explain your concern in more detail if it persists.
> >
> > What about changing the naming/adding comments here, so that (1) folks
> > aren't confused by the same thing in the future and (2) folks don't try
> > to use that pool for something needed for the early ccw consoles?
> >
>
> I'm all for clarity! Suggestions for better names?

css_aiv_dma_pool, maybe? Or is there other cross-device stuff that may
need it?