Re: [PATCH 05/10] s390/cio: introduce DMA pools to cio

Halil Pasic
2019-05-23T15:17:56Z

On Wed, 8 May 2019 15:18:10 +0200 (CEST)
Sebastian Ott <sebott@linux.ibm.com> wrote:

> > @@ -224,6 +228,9 @@ struct subchannel *css_alloc_subchannel(struct subchannel_id schid,
> > INIT_WORK(&sch->todo_work, css_sch_todo);
> > sch->dev.release = &css_subchannel_release;
> > device_initialize(&sch->dev);
> > + sch->dma_mask = css_dev_dma_mask;
> > + sch->dev.dma_mask = &sch->dma_mask;
> > + sch->dev.coherent_dma_mask = sch->dma_mask;
>
> Could we do:
> sch->dev.dma_mask = &sch->dev.coherent_dma_mask;
> sch->dev.coherent_dma_mask = css_dev_dma_mask;
> ?

Looks like a good idea to me. We will do it for all 3 (sch, ccw and
css). Thanks!

Regards,
Halil