Re: [PATCH 03/10] virtio/s390: enable packed ring

Cornelia Huck
2019-05-03T09:44:50Z

On Fri, 26 Apr 2019 20:32:38 +0200
Halil Pasic <pasic@linux.ibm.com> wrote:

> Nothing precludes to accepting VIRTIO_F_RING_PACKED any more.

"precludes us from accepting"

>
> Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
> ---
> drivers/s390/virtio/virtio_ccw.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c
> index 42832a164546..6d989c360f38 100644
> --- a/drivers/s390/virtio/virtio_ccw.c
> +++ b/drivers/s390/virtio/virtio_ccw.c
> @@ -773,10 +773,8 @@ static u64 virtio_ccw_get_features(struct virtio_device *vdev)
> static void ccw_transport_features(struct virtio_device *vdev)
> {
> /*
> - * There shouldn't be anything that precludes supporting packed.
> - * TODO: Remove the limitation after having another look into this.
> + * Currently nothing to do here.
> */
> - __virtio_clear_bit(vdev, VIRTIO_F_RING_PACKED);
> }
>
> static int virtio_ccw_finalize_features(struct virtio_device *vdev)

Not sure whether we should merge this into the previous patch instead.
Anyway, I think we can go ahead with that for 5.2 as well.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>