Re: [PATCH 10/10] virtio/s390: make airq summary indicators DMA

Halil Pasic
2019-05-15T17:23:44Z

On Wed, 15 May 2019 15:33:02 +0200
Michael Mueller <mimu@linux.ibm.com> wrote:

> >> @@ -273,8 +281,9 @@ static unsigned long get_airq_indicator(struct
> >> virtqueue *vqs[], int nvqs,
> >>       unsigned long bit, flags;
> >>       for (i = 0; i < MAX_AIRQ_AREAS && !indicator_addr; i++) {
> >> +        /* TODO: this seems to be racy */
> >
> > yes, my opinions too, was already racy, in my opinion, we need another
> > patch in another series to fix this.
> >
> > However, not sure about the comment.
>
> I will drop this comment for v2 of this patch series.
> We shall fix the race with a separate patch.

Unless there is somebody eager to address this real soon, I would prefer
keeping the comment as a reminder.

Thanks for shouldering the v2!

Regards,
Halil