From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: Re: [PATCH v3 3/7] drivers: parisc: Avoids building driver if CONFIG_PARISC is disabled Date: Fri, 5 Oct 2018 14:10:04 +1000 (AEST) Message-ID: References: <20180928020816.11251-1-leobras.c@gmail.com> <20180928020816.11251-4-leobras.c@gmail.com> <1538118915.3593.4.camel@HansenPartnership.com> <1538628062.18776.5.camel@HansenPartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: List-Archive: List-Post: To: Leonardo Bras Cc: James Bottomley , lkcamp@lists.libreplanetbr.org, Alexander Shishkin , Robert Richter , "James E.J. Bottomley" , Helge Deller , Martin Schwidefsky , Heiko Carstens , Geert Uytterhoeven , linux-kernel , linux-m68k@lists.linux-m68k.org, oprofile-list@lists.sf.net, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org List-ID: On Thu, 4 Oct 2018, Leonardo Bras wrote: > ... > But, why these chosen Makefiles, and not all of them? I think that inconsistency is untenable. If nothing else, it means your changes will get broken by other people who also apply constraints inconsistently. I think you need to consider what happens when you apply this regime tree-wide. Either that or explain why it would make sense to build e.g. drivers/s390 but not drivers/s390/net. --