From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:59048 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbgGQJGd (ORCPT ); Fri, 17 Jul 2020 05:06:33 -0400 Date: Fri, 17 Jul 2020 11:06:31 +0200 (CEST) From: Miroslav Benes Subject: Re: [PATCH 3/3] arm64: stacktrace: Convert to ARCH_STACKWALK In-Reply-To: <20200716162022.GD5105@sirena.org.uk> Message-ID: References: <20200715202821.12220-1-broonie@kernel.org> <20200715202821.12220-4-broonie@kernel.org> <20200716162022.GD5105@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-s390-owner@vger.kernel.org List-ID: To: Mark Brown Cc: Catalin Marinas , Will Deacon , Heiko Carstens , Vasily Gorbik , Thomas Gleixner , Borislav Petkov , "H. Peter Anvin" , Christian Borntraeger , Ingo Molnar , Jiri Slaby , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org On Thu, 16 Jul 2020, Mark Brown wrote: > On Thu, Jul 16, 2020 at 01:56:13PM +0200, Miroslav Benes wrote: > > On Wed, 15 Jul 2020, Mark Brown wrote: > > > > -void save_stack_trace(struct stack_trace *trace) > > > -{ > > > - __save_stack_trace(current, trace, 0); > > > + walk_stackframe(task, &frame, consume_entry, cookie); > > > } > > > just an idea for further improvement (and it might be a matter of taste). > > Yeah, there's some more stuff that can be done - the reason I'm looking > at this code is to do reliable stack trace which is going to require at > least some changes to the actual unwinder, this just seemed like a > useful block moving things forwards in itself and I particularly wanted > feedback on patch 1. Understood. Reliable stack traces would be an important step for live patching on arm64, so I am looking forward to seeing that. Thanks Miroslav