From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AD26471CFD for ; Wed, 19 Aug 2026 11:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787140210; cv=none; b=pmiS4U0dHT6IM7msQ5YI3wL8e5v2CN+7Z3k+maSBWycOGpjHk0pHLT7q92QVTzVo325ZvKIQk9pKvzruk+37LfI0joqb0YauHtm3pQ3q4FI71eDuqNUaRhlZ/0eXCBoMJUBhaQsGPLW2zQjHnYBH7GvMafxOsz9Y0a8oXh6H9JM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787140210; c=relaxed/simple; bh=dLbO/KZ9p8AfNKJwP2FWUdac1cvSGmTwIke+Nm9losM=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XH6tC+mlBpPxQJDKkQOo/HObM2icyIv4lUNG7gySybekhwSy4q7FC6pkH/T9w4ncWjX1F7iT+9TZXuZB2F0G3Hz/Z2PT/mDr3YfpAjk4bNw9px+wqeP3Ld4l9FBuLxiWGO4RjHtgtVY+Td1VoJzLs2Vrz9yV70LZt1+Qq6R4LMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AL5UHIHA; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AL5UHIHA" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-39f1ac13687so6139741fa.0 for ; Wed, 19 Aug 2026 04:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787140204; x=1787745004; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=qb8vbO35I9ReDoy08LYZaOcpJWIqiGdFJcRUGNTu904=; b=AL5UHIHAef6lcN8kJ5xWmpUSc6DfKmb5R5GES6ugTd4YzL9tFeF25Oqj696fCo5iMk 4iNI+IK4qfOa+KtCsR3TQjcAsNqWGen9z0sLlnIKNmF7g+7bG1DB0yGMy7lnpZM2sJFC HR2uemSYF23n6jDeQBdNgmzjIXgCLfGkPKOuKJVpod9z6jIoLWSyh7V6sk3vcxX2KIwx FoSWHZX21uaCSAlF8LLnjmoHg4zP8tyoGJ5IArD8snEWxgb4lmjpv4qFCimSTFi9Q2uD uEnxGT8IeWExka3oNuUTcb1wnn6stWEyhkQ4Hce2XGOj0GV9xNHh2uIS+tHhO6fUV0HZ NDIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787140204; x=1787745004; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qb8vbO35I9ReDoy08LYZaOcpJWIqiGdFJcRUGNTu904=; b=sfUpwuae2A9eraLS7IyVYnqr0rtNmbZ+kgX2WbJYuA6TxTg2hBkIei3MX/eHQgcyHx /sadyWVOdCuo/SXp7Ja1dvEYt8pw8FO5ujOxMl2I2UWEIxv3w4vwEwVHcf5YRUGabGHr cp8hFt3OOjxjzK1xzXwj0xUWs8FvarNxvR6MFZkg7h7ZL0lRHYzAG7aL+/Rz1Aj78ISu Pw8FU+Sh68su8txMs/0tjQ8WwH/0LxvlZVe3uQUD/LwoGQQGqn8onDmwJnEx8KLgaLcA pb1oKBwltESCcPJw4z3JSvl+MUAX1SkIjMxGZmCw2s55oUcT1pnsCoFQG0T14Fc2oONk XbXQ== X-Forwarded-Encrypted: i=1; AHgh+RpDvi6deY5LgHWQLyg7EMl+ddP2Bq9w5qjPhAhtBEhhDg7a71RXvaI5eG1h/yN8xvn4WVrdWC0UjL5D@vger.kernel.org X-Gm-Message-State: AOJu0YxkPChRnzS4ySGjOAUcKCOY85FRX79FVSNTaDYvW/avpWbjGUzd b3W0C7o1UDtPVbBp8cDi7NVFY7S2/G6lU8VjpFJHplBb+xTaoqj8UyJA X-Gm-Gg: AR+sD13y/OTfesABF98Pii+vkpoWrXNLAOBgD2lls9E1YYhchFO8wO36qyu1YFqVt0w slH7HfJCtS0+6rdhImLNTI1iWwcTAF0V/Bjvg1yC2VV4UNhVBa6cZCwNki7gbrZa/YK+UcZjij7 blB9RShsmr6USbnfxj9iE1Y1G1bxY4thfhkD48HWW3LWOlcYUcjZwU4iJGbrF+yc7Ch1Vzhc0na ESCGdEy8bQBTUTHCi4hiGu1mDRgAlDAY5KJ4OBV6W2V0wdP7tj3SHhjTpJhf5FuEIc5yJQOv/ma CEbuK5wRj81mMTYgiDQDb0poBcxzZNNdIrjNuoORSutXSO6bL4kD3N1eNwECzeT30BMni6plqn2 k+6nZStarYiDob44vvD8C4Vpv5jIXbFko/OC/Cx3d/O8gkPPZIMaQneuIDCn20gUuzJhhut3VaN rjo77ykXMK/wyrWrYzi/J9N4IOVCgca8pczsNB2ac4bGLhC+njVISs3t48ATxA/RgyuYyEuxUOD 5G99BZ57XMN/DnKmJU= X-Received: by 2002:a05:651c:3135:b0:39b:48c1:8cd4 with SMTP id 38308e7fff4ca-3a18996bd7dmr7858151fa.7.1787140203900; Wed, 19 Aug 2026 04:50:03 -0700 (PDT) Received: from pc636 (host-95-193-137-165.mobileonline.telia.com. [95.193.137.165]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a18a8e8579sm4123321fa.0.2026.08.19.04.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 04:50:03 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 19 Aug 2026 13:49:58 +0200 To: "Mike Rapoport (Microsoft)" Cc: Andrew Morton , Adrian =?utf-8?Q?Barna=C5=9B?= , Albert Ou , Alexander Gordeev , Alexandre Ghiti , Andy Lutomirski , Borislav Petkov , Brendan Jackman , Catalin Marinas , Christian Borntraeger , Dave Hansen , David Hildenbrand , Gerald Schaefer , Heiko Carstens , Huacai Chen , Ingo Molnar , Len Brown , Palmer Dabbelt , Paul Walmsley , Pavel Machek , Peter Zijlstra , "H. Peter Anvin" , "Rafael J. Wysocki" , Ryan Roberts , Sven Schnelle , Thomas Gleixner , Uladzislau Rezki , Vasily Gorbik , WANG Xuerui , Will Deacon , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, loongarch@lists.linux.dev Subject: Re: [PATCH 3/6] mm/vmalloc: constify vm parameter of get_vm_area_page_order() Message-ID: References: <20260816-execmem-set-vm-perms-v0-2-v1-0-90944a3ad43f@kernel.org> <20260816-execmem-set-vm-perms-v0-2-v1-3-90944a3ad43f@kernel.org> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260816-execmem-set-vm-perms-v0-2-v1-3-90944a3ad43f@kernel.org> On Sun, Aug 16, 2026 at 01:59:26PM +0300, Mike Rapoport (Microsoft) wrote: > get_vm_area_page_order() and vm_area_page_order() do not need to modify > struct vm_struct passed to them. > > Constify the parameter. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > mm/vmalloc.c | 4 ++-- > mm/vmalloc.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 6822f0fe9583..fc7993db4152 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3124,7 +3124,7 @@ EXPORT_SYMBOL(vm_map_ram); > > static struct vm_struct *vmlist __initdata; > > -static inline unsigned int vm_area_page_order(struct vm_struct *vm) > +static inline unsigned int vm_area_page_order(const struct vm_struct *vm) > { > #ifdef CONFIG_HAVE_ARCH_HUGE_VMALLOC > return vm->page_order; > @@ -3133,7 +3133,7 @@ static inline unsigned int vm_area_page_order(struct vm_struct *vm) > #endif > } > > -unsigned int get_vm_area_page_order(struct vm_struct *vm) > +unsigned int get_vm_area_page_order(const struct vm_struct *vm) > { > return vm_area_page_order(vm); > } > diff --git a/mm/vmalloc.h b/mm/vmalloc.h > index 8866ddcff668..211869f36509 100644 > --- a/mm/vmalloc.h > +++ b/mm/vmalloc.h > @@ -12,7 +12,7 @@ void __init vmalloc_init(void); > int __must_check vmap_pages_range_noflush(unsigned long addr, unsigned long end, > pgprot_t prot, struct page **pages, > unsigned int page_shift, gfp_t gfp_mask); > -unsigned int get_vm_area_page_order(struct vm_struct *vm); > +unsigned int get_vm_area_page_order(const struct vm_struct *vm); > #else > static inline void vmalloc_init(void) {} > > > -- > 2.53.0 > LGTM: Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki