From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FF034A5EA7 for ; Wed, 2 Sep 2026 16:20:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788366027; cv=none; b=mWS1JEfqhtMlR6tcp4kSJ76Eq4y7PmK1W9XTDoa2d/metqWZQpdSB01ra4i6ygL8fpX+pbDXpPD+fp2s5F97rCtBSYU66/08Kkn7m7yTZ3eYIoeDiTVyXE9wvkPzI20oHuXxqoNGVb8NPWWzp39YByMoMG2a3njnu43ezppMjfk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788366027; c=relaxed/simple; bh=kirF1Z6H1us8C+w/nRlLFHvxONxvS/UzEcyYUHsaSLA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=p4ghqo90cYDYJ1+85PYL/4Bg8qJn6bMmud7x8l8qx/iKTtkXfMOXKvI0sdDuUJuU5q12JD5Q6T5BMhncrJDEVECB6SPm85ASLxd/iYgnPvMcgT61WI17oILpTG+pHcPxhIag/ebzb+Lf7fJ2mIumpA2Qs5GCZars4UtUz2DBOec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=APn0ZqVf; arc=none smtp.client-ip=209.85.215.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="APn0ZqVf" Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cc4216aee8fso1306724a12.1 for ; Wed, 02 Sep 2026 09:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1788366024; x=1788970824; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nmUHQDRJovGy5euybNv8U4I384UlmmpWUQBP5c7RHzY=; b=APn0ZqVf2NzKu9DA1ZSd4dyGrIK2gNQc4BG7tco9uyQFfl+YByZN4lUWNNOKve94uL Ne3yu95UWyseAq2Np15elhcPv4GPk9fiLo37iKAzQDxEtKJnnUTSGWjE1bZOLUwv9hIm ZDX4o41/iNPSxhGSEgrk05bJ2DdPypsB/DJ7DQ6l9efca4KPldLXUczRCvwja4881+V7 CS72tggD7ty30ZmcUF+IuUVpWUU0aMH6fvlNwfPtjcqT0AWDJrOG+EC77PJoJ7UXuGgJ pYe5thrKOyXG1y+THPqGmBIS7RC5ZPQwsxjXNy1tjClnVHK21tcaP+CYIak59R9K3jvk MZGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788366024; x=1788970824; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nmUHQDRJovGy5euybNv8U4I384UlmmpWUQBP5c7RHzY=; b=LbviGvwIMuxrd10uAI7MlLXsKjY2BUPNWIML95hCvaQuCMZ54wv6yzCmJA/OkDB1R5 56CDA18diEY+zdQ6DshzVg1oAlWht7Y1DjJqBWwq95EtLgRQodEtbj6Hk0UdqCvcWg72 7CkgLVn96ytHCQSPkFwDaf8GNb9lE+0tE+O8taJmGIQb9g4YzhuR/a4p22Swy5uDAhFk G7zrdO26xM5/AOrOrknN7FP+HXnfmoCw7teIdgYWMZREUqtwNIybPDThVV8OGNsFA71v HApvNJeM3/r0/Ua1PFX89+QIfVAkjqmSyiaE7HTe1TwnnfSajfA+fTKRC5IUJ2Nmnt8s irMg== X-Forwarded-Encrypted: i=1; AHgh+RrLhFyyIXdqg4CcubRtSCd8nZfM/INBhdypHkjV+7uLByvEj2iuNz2GzL6Wu4RJnMonNn+dOWn+Ep4V@vger.kernel.org X-Gm-Message-State: AFuF++kRpztE/nHL9MMSXulhVNBOomv3JY/a5IygCU5btYKbl+M1Do4d xBgcbkFNOhyztqq8dZZrpwByK75t8xfmDnFChUtEK1vYk0h+b5VOhC2u+UY2ovJtH+88rM5Evvw UOVRUyQ== X-Received: from pgp27-n1.prod.google.com ([2002:a05:6a02:62db:10b0:cbe:e120:3788]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:2d22:b0:3d3:aec2:4dcb with SMTP id adf61e73a8af0-3d9b051aa7dmr10390341637.23.1788366023624; Wed, 02 Sep 2026 09:20:23 -0700 (PDT) Date: Wed, 2 Sep 2026 09:20:23 -0700 In-Reply-To: <20260831144802.834315-24-seiden@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260831144802.834315-1-seiden@linux.ibm.com> <20260831144802.834315-24-seiden@linux.ibm.com> Message-ID: Subject: Re: [PATCH v7 23/23] KVM: s390: arm64: Add KVM_S390_ARM64 Kconfig and Makefile From: Sean Christopherson To: Steffen Eiden Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Alexander Gordeev , Andreas Grapentin , Arnd Bergmann , Catalin Marinas , Christian Borntraeger , Claudio Imbrenda , David Hildenbrand , Friedrich Welter , Fuad Tabba , Gautam Gala , Hariharan Mari , Heiko Carstens , Hendrik Brueckner , Ilya Leoshkevich , Janosch Frank , Joey Gouly , Marc Zyngier , Nico Boehr , Nina Schoetterl-Glausch , Oliver Upton , Paolo Bonzini , Suzuki K Poulose , Sven Schnelle , Ulrich Weigand , Vasily Gorbik , Will Deacon , Zenghui Yu Content-Type: text/plain; charset="us-ascii" On Mon, Aug 31, 2026, Steffen Eiden wrote: > diff --git a/arch/s390/kvm/Kconfig b/arch/s390/kvm/Kconfig > index 8d3ee17a1bcb..9c69ea16031e 100644 > --- a/arch/s390/kvm/Kconfig > +++ b/arch/s390/kvm/Kconfig > @@ -53,4 +53,33 @@ config KVM_S390_UCONTROL > > If unsure, say N. > > +config KVM_S390_ARM64 > + def_tristate y > + prompt "KVM support for hardware accelerated arm64 guests" > + depends on HAS_IOMEM > + depends on KVM Is this actually necessary? I.e. does kvm.ko need to be *loaded* in order for kvm-arm64.ko to be loaded? If kvm-arm64.ko does indeed have a hard dependency on kvm.ko, then I think it makes sense to not have redundant "select" statements below. As an outsider, it's super confusing because the KVM_S390_ARM64 are incomplete, e.g. are lacking things like VIRT_XFER_TO_GUEST_WORK (at least, I assume those are lacking), and makes it hard to see what is actually unique to kvm-arm64.ko. If kvm-arm64.ko doesn't have a dependency on kvm.ko, e.g. to initialize hardware or something, then this "depends on" should go away.