From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B6F44E56CE for ; Thu, 3 Sep 2026 15:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788450519; cv=none; b=GCDfxr/aq/vrA7OqSY8G3ZP+nqfRUTZ0i1dSiPQmW33sX2ALiAyRHsNZqxZEH/y0bp0VwncYHFy3w95ax1IxsTT/wRw6uuXZPjZUQTeINyGi3xxtyTXf7wYbd06HLTyCZ3DyB6vMkPvBxaC9frL94JXVrhB1UI4F9ZKhbNtfmw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788450519; c=relaxed/simple; bh=qKmRoYSbK4pggjfQTTrO8FbbOoauwacbfUdwqi26JN8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=DHPU9cVdW6VBAEyZuAezu0mawX3eJCUeOj9v5YR1F9jjbpemtsqMTydlg6UofublW7ogd0pCh4BUzNAduFIOxN0dJw3OHzcJXPDKWAcHiMioG6Nl+b5xMs8lfMuwDuetgGqUrtGvSsMvBSVOWsvc5o/qawyZ+ps/KDls+wavJgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dSEKNUit; arc=none smtp.client-ip=209.85.214.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dSEKNUit" Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2d001671a54so43861945ad.2 for ; Thu, 03 Sep 2026 08:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1788450517; x=1789055317; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PmHR9VMSgZvTyS5Rd9T+V8oik7z2Cr4I+UuO+iaoSDc=; b=dSEKNUitVPGXgu5NXqV/b4gRUizHj/nDbdrMqeQ1bUV1Sd91iJOG/ei6bu7zt2KMGM 1lXEEPxyQ377bb/NqriW7/odVkHo6SchsNsSxm7+QKQB1gpSthXVFub2BzaHB5c93Jz6 evE5nVPgubHZdv4aZLcYRiF37gzHCL2gq2+4plh2/2ghKBh4xy2l0EpbJoMa/SVgXXbQ QcNbxsb/gW2Yop0ZYbKf44iqiBCCFIDMxAdc1Q5Twndrgjfg4K1ko/82vPdTEwPTD9Ep W0ARJF+r0D6Ygox8dYozz1b4wK3Os0jKE1YLjnvucQi5OmG2mh/D5z4OAUF98KRZww/x Jd3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788450517; x=1789055317; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PmHR9VMSgZvTyS5Rd9T+V8oik7z2Cr4I+UuO+iaoSDc=; b=jH9bI/cqvepNZMn7nUAZ7kcnlHFCY4gJ/ZI2jdoUju7U0xyIulLFbCYFcooj3jD37D PQBpmgTINjwT9CZSVe8d3ExtnEV+pmKB4Q0htrViZOHwcO/9VZ5zQssbjME2bqNDQmcV hfEPCJMU5SO8ucrp5YD9/GXXiSWJRdzGHw6z37TSBTAo4WtKWSGPUJzvYvwtzZGQ63qh N2qcCVSjyZh/71QfzXIyGlI89b8rvqr2myWOXUSEbDblwQLYPI2AA0tG6mPFBleM8v/G viocXYs53I3APUF+C45UMLrSRRPIMQZK1moiQysgaSvZ35LNScf8/YHzzCTukRBYBNA6 x9RA== X-Forwarded-Encrypted: i=1; AKwUvBzI2M9tV7Qg8pwA4HRHsnV/hbV3jHIZAS+nKzBCOe7f1B8nWduW1JrIeT36q07z91QRbvvTjksyfqja@vger.kernel.org X-Gm-Message-State: AFuF++mu4zhQNF3HlgP0xr8Uoh/EshClgoqJMw6ZySH3aFEAiqUHT71O VBRHJGMdkgj14Bb/jbYz0DLuTEQxfGIR+ZeI9rh8puvuV3Ye9jlYc7aFoMrKvzjvnf/PQ2imftW K+bL1dg== X-Received: from plce19.prod.google.com ([2002:a17:902:f1d3:b0:2d9:2fc7:bb3d]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f78c:b0:2c9:df1b:e948 with SMTP id d9443c01a7336-2daec5dfa20mr199165855ad.4.1788450516176; Thu, 03 Sep 2026 08:48:36 -0700 (PDT) Date: Thu, 3 Sep 2026 08:48:35 -0700 In-Reply-To: <20260903114241.33034-C-seiden@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260831144802.834315-1-seiden@linux.ibm.com> <20260831144802.834315-3-seiden@linux.ibm.com> <20260902075028.231001-D-seiden@linux.ibm.com> <20260903114241.33034-C-seiden@linux.ibm.com> Message-ID: Subject: Re: [PATCH v7 02/23] KVM: Make device name configurable From: Sean Christopherson To: Steffen Eiden Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Alexander Gordeev , Andreas Grapentin , Arnd Bergmann , Catalin Marinas , Christian Borntraeger , Claudio Imbrenda , David Hildenbrand , Friedrich Welter , Fuad Tabba , Gautam Gala , Hariharan Mari , Heiko Carstens , Hendrik Brueckner , Ilya Leoshkevich , Janosch Frank , Joey Gouly , Marc Zyngier , Nico Boehr , Nina Schoetterl-Glausch , Oliver Upton , Paolo Bonzini , Suzuki K Poulose , Sven Schnelle , Ulrich Weigand , Vasily Gorbik , Will Deacon , Zenghui Yu Content-Type: text/plain; charset="us-ascii" On Thu, Sep 03, 2026, Steffen Eiden wrote: > On Wed, Sep 02, 2026 at 09:14:21AM -0700, Sean Christopherson wrote: > > On Wed, Sep 02, 2026, Steffen Eiden wrote: > > > On Tue, Sep 01, 2026 at 05:40:25PM -0700, Sean Christopherson wrote: > > > > On Mon, Aug 31, 2026, Steffen Eiden wrote: > > > > > Allow KVM implementations to choose alternative device names. This is > > > > > especially useful for architectures providing multiple KVM > > > > > implementations simultaneously. Architectures providing multiple KVM > > > > > implementations must compile the KVM common code once per > > > > > implementation and mange symbols. > > > > > > > > What about tracepoints? Or do those show up as "kvm" and "kvm-arm64"? > > > > > > Yes, I want them to show up as kvm and kvm-arm64. > > > > > > Thanks for pointing that out - I just noticed that I forgot to switch > > > the trace system to kvm-arm64 for the common tracepoints in > > > trace/events/kvm.h > > > I only did it for the arch-local traces in PATCH 21. > > > > > > I would just do the following: > > > > > > diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h > > > index b282e3a86769..5d4f8a0693a3 100644 > > > --- a/include/trace/events/kvm.h > > > +++ b/include/trace/events/kvm.h > > > @@ -5,7 +5,11 @@ > > > #include > > > > > > #undef TRACE_SYSTEM > > > +#ifdef KVM_S390_ARM64 > > > > Side topic, I recommend choosing a macro name that doesn't have a near-collision > > with CONFIG_KVM_S390_ARM64. This *looks* like a typo, i.e. it looks like you > > forgot the CONFIG_ prefix. Especially since the macro is defined in the Makefile > > and won't show up with e.g. "git grep -w KVM_S390_ARM64". E.g. KVM_S390_BUILD_ARM64 > > or something? > > Interesting. The name was deliberately chosen to be similar. But I > see that it could be confusing. > > I am not totally happy with KVM_S390_BUILD_ARM64 but I cannot find a > better name either. Y'all need to pick *one* method. KVM_S390_MANAGES_S390_GUEST was already added by a07276d5d188 ("KVM: s390: gmap: Make storage keys optional"), and then this series effectively adds another macro to provide the inversion of that, except they're not even tied together.