Re: [PATCH v2 1/4] s390/cio: Make struct css_driver::remove return void

Cornelia Huck
2021-07-06T15:58:33Z

On Tue, Jul 06 2021, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> The driver core ignores the return value of css_remove()
> (because there is only little it can do when a device disappears) and
> there are no pci_epf_drivers with a remove callback.

s/pci_epf/css/

>
> So make it impossible for future drivers to return an unused error code
> by changing the remove prototype to return void.
>
> The real motivation for this change is the quest to make struct
> bus_type::remove return void, too.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/s390/cio/chsc_sch.c | 3 +--
> drivers/s390/cio/css.c | 7 ++++---
> drivers/s390/cio/css.h | 2 +-
> drivers/s390/cio/device.c | 5 ++---
> drivers/s390/cio/eadm_sch.c | 4 +---
> drivers/s390/cio/vfio_ccw_drv.c | 3 +--
> 6 files changed, 10 insertions(+), 14 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>