From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [RFC PATCH 4/7] kconfig: support new special property shell= References: <20180210054843.z3g7wvcmlccvww3h@huvuddator> <20180210074924.3nhxsza5zdbaahxx@huvuddator> <20180210080556.mycqsjhxbaguwhay@huvuddator> <20180210085519.737ckf4bcl57h4g2@huvuddator> <20180211103432.pf2ot6nd7nbhdhsy@huvuddator> <49c196ec-891d-2030-bd6c-7222feb22059@infradead.org> From: Randy Dunlap Message-ID: Date: Mon, 12 Feb 2018 17:53:05 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-Archive: List-Post: To: Masahiro Yamada Cc: Kees Cook , Ulf Magnusson , Linus Torvalds , Linux Kbuild mailing list , Greg Kroah-Hartman , Andrew Morton , Nicolas Pitre , "Luis R . Rodriguez" , Sam Ravnborg , Michal Marek , Martin Schwidefsky , Pavel Machek , linux-s390 , Jiri Kosina , Linux Kernel Mailing List , Tejun Heo , Ingo Molnar , "Van De Ven, Arjan" , Arnd Bergmann List-ID: On 02/12/2018 05:41 PM, Masahiro Yamada wrote: > 2018-02-13 8:48 GMT+09:00 Randy Dunlap : >> On 02/12/2018 07:24 AM, Kees Cook wrote: >>> On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada >>> wrote: >> >>>>> (And in thinking about this, does Kconfig know the true $CC in use? >>>>> i.e. the configured cross compiler, etc?) >>>> >>>> I was thinking of removing CONFIG_CROSS_COMPILE. >>>> >>>> A user can dynamically change CROSS_COMPILE from >>>> "make menuconfig". >>> >>> Most builds I've seen implement cross compilers as an environment >>> variable during all "make" invocations. >> >> I agree. I think you would break a bunch of build bots if you remove that. > > > For clarification, I suggested to remove CONFIG_CROSS_COMPILE. > > The following code: > https://github.com/torvalds/linux/blob/v4.16-rc1/Makefile#L315 > https://github.com/torvalds/linux/blob/v4.16-rc1/init/Kconfig#L58 > > I hope build bots are not using this. > > > Passing CROSS_COMPILE via the command line, environment > is still supported. OK, I misunderstood. That one can go away IMO. thanks, -- ~Randy