From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 005D8C433F5 for ; Fri, 21 Jan 2022 16:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344758AbiAUQgZ (ORCPT ); Fri, 21 Jan 2022 11:36:25 -0500 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:58245 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234718AbiAUQgY (ORCPT ); Fri, 21 Jan 2022 11:36:24 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R221e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=guangguan.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0V2SImAL_1642782981; Received: from 30.39.181.79(mailfrom:guangguan.wang@linux.alibaba.com fp:SMTPD_---0V2SImAL_1642782981) by smtp.aliyun-inc.com(127.0.0.1); Sat, 22 Jan 2022 00:36:22 +0800 Message-ID: Date: Sat, 22 Jan 2022 00:36:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [RFC PATCH net-next] net/smc: Introduce receive queue flow control support Content-Language: en-US To: Karsten Graul , davem@davemloft.net, kuba@kernel.org Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220120065140.5385-1-guangguan.wang@linux.alibaba.com> <20da5fa9-6158-d04c-6f44-29e550ed97d0@linux.ibm.com> From: Guangguan Wang In-Reply-To: <20da5fa9-6158-d04c-6f44-29e550ed97d0@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 2022/1/20 19:03, Karsten Graul wrote:> > I really appreciate your effort to improve the performance and solve existing bottle necks, > but please keep in mind that the SMC module implements the IBM SMC protocol that is > described here: https://www.ibm.com/support/pages/node/6326337 > (you can find these links in the source code, too). > > Your patch makes changes that are not described in this design paper and may lead to > future incompatibilities with other platforms that support the IBM SMC protocol. > > For example: > - you start using one of the reserved bytes in struct smc_cdc_msg > - you define a new smc_llc message type 0x0A > - you change the maximum number of connections per link group from 255 to 32 > > We need to start a discussion about your (good!) ideas with the owners of the protocol. Thanks for your affirmation of my effort and looking forward to the conclusion of the protocol discussion.