From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: Date: Wed, 13 Aug 2008 00:04:11 -0700 From: "Tim Hockin" Subject: Re: [patch 1/3] kmsg: Kernel message catalog macros. In-Reply-To: <200808131433.02966.rusty@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080730165656.118280544@de.ibm.com> <20080730171156.824640459@de.ibm.com> <200808131433.02966.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Rusty Russell Cc: Martin Schwidefsky , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, lf_kernel_messages@lists.linux-foundation.org, Andrew Morton , Michael Holzheu , Gerrit Huizenga , Greg Kroah-Hartman , Randy Dunlap , Jan Kara , Pavel Machek , Sam Ravnborg , Joe Perches , =?UTF-8?Q?Jochen_Vo=C3=9F?= , Kunai Takashi , Tim Bird List-ID: But there are a number of places that have different strings for the same meaning: "Can't" vs "can't" vs "can not" vs "failed to", etc. This is a big part of what hurts us - you end up with lots of loose regexes when parsing logs. Tim On Tue, Aug 12, 2008 at 9:33 PM, Rusty Russell wrote: > On Thursday 31 July 2008 02:56:57 Martin Schwidefsky wrote: >> From: Michael Holzheu >> From: Martin Schwidefsky >> >> Introduce a new family of printk macros which prefixes each kmsg message >> with a component name and allows to tag the printk with a message id. > > Can you hash the format string to generate the id? 6 hex digits should be > enough, and your tool can check for clashes. As it's bad form to have > identical strings for different semantics anyway, this seems to make sense. > > Rusty. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >