Re: [PATCH v1 3/4] s390x:irq: make IRQ handler weak

Thomas Huth
2019-11-15T07:12:48Z

On 13/11/2019 13.23, Pierre Morel wrote:
> Having a weak function allows the tests programm to declare its own IRQ
> handler.
> This is helpfull when developping I/O tests.
> ---
> lib/s390x/interrupt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/s390x/interrupt.c b/lib/s390x/interrupt.c
> index 7aecfc5..0049194 100644
> --- a/lib/s390x/interrupt.c
> +++ b/lib/s390x/interrupt.c
> @@ -140,7 +140,7 @@ void handle_mcck_int(sregs_t *regs)
> lc->mcck_old_psw.addr);
> }
>
> -void handle_io_int(sregs_t *regs)
> +__attribute__((weak)) void handle_io_int(sregs_t *regs)
> {
> report_abort("Unexpected io interrupt: at %#lx",
> lc->io_old_psw.addr);
>

Reviewed-by: Thomas Huth <thuth@redhat.com>