From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C311C00A8F for ; Tue, 24 Oct 2023 07:09:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232433AbjJXHJx (ORCPT ); Tue, 24 Oct 2023 03:09:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232686AbjJXHJw (ORCPT ); Tue, 24 Oct 2023 03:09:52 -0400 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DF8311A; Tue, 24 Oct 2023 00:09:49 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9C7A65C021E; Tue, 24 Oct 2023 03:09:47 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 24 Oct 2023 03:09:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1698131387; x=1698217787; bh=VA PNQYkTt0iwP9E8BmBBBQ+AGuWLrzjahGWfYfAXDTU=; b=Iq4nMqJFt+QLEijmKe DhAWakAxAABCKSDqfnaR7YZKp4C6NkJZ7ND4rULfLCcWRIEj58zanM9wGS2zfa9Y zigc9N6twVfBtoHb/7q4T963hfjST3MCVZ69hA4FycedX/nr9jIzsex4nucM165b 8S8lq3MNfxN8fNi8+2PM3PuPa6UGG93xLRMvbARixKI5IKAQRtgmx3clr8nTEZSt +g1ZXJDAC6vM+1+xWssNnwtYQ6mtYd/Chgcy92evrvdUNiEnzAkCM50GbexM/Zyf X+w5MwhnYlmccfEa/uRh05Yi8KNQhavZRGBkeCTeru9JfgYC3qFr4kJkJzvnsDXD BRyQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1698131387; x=1698217787; bh=VAPNQYkTt0iwP 9E8BmBBBQ+AGuWLrzjahGWfYfAXDTU=; b=GrXfpeE3r3mgoKD0ZLFpG4MFcGkPs 64U5UZhK0ca0Gplz9Bo7SHqhv+yZmBg+COuY1I1hzcwBcVJ/jeWSVRTdCHCPzh29 Kf/ZA6fC4x18y/S770OfsOykJYvIHKs348pkPCngIVeSm+SxUEDlFqXWvmPKzfPr 19nTjJuvTXn2bftghg3s2Br7hXIAZlt3TGJDuL+Nj+kgVCpLaTtCWjaNDShU+YBP SFyHmxcYrpUUGVEcf5ijCNaA2AE2zpUSLSeaiQUURwLVEtCLsUeltQzwAFp3jhBR MJQCUQUBSM+v/yfA32pWu79lRI9MEuCNPnLIOA0EbWWMz1KsiIL/sN9uA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrkeejgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepvefhffeltdegheeffffhtdegvdehjedtgfekueevgfduffettedtkeekueef hedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id DE6A7B60089; Tue, 24 Oct 2023 03:09:45 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1048-g9229b632c5-fm-20231019.001-g9229b632 MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20231023110308.1202042-1-arnd@kernel.org> <20231023110308.1202042-2-arnd@kernel.org> Date: Tue, 24 Oct 2023 09:09:25 +0200 From: "Arnd Bergmann" To: "Baoquan He" , "Arnd Bergmann" Cc: "Vivek Goyal" , "Andrew Morton" , "Herbert Xu" , "David S . Miller" , linux-crypto@vger.kernel.org, "Nicholas Piggin" , "Christophe Leroy" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" , "Sven Schnelle" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , x86@kernel.org, "H. Peter Anvin" , "Eric DeVolder" , "Peter Zijlstra" , "Ard Biesheuvel" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, "Hari Bathini" , "Costa Shulyupin" Subject: Re: [PATCH 2/2] kexec: select CRYPTO from KEXEC_FILE instead of depending on it Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Tue, Oct 24, 2023, at 06:10, Baoquan He wrote: > On 10/24/23 at 11:55am, Baoquan He wrote: >> On 10/23/23 at 01:01pm, Arnd Bergmann wrote: >> > From: Arnd Bergmann >> > >> > All other users of crypto code use 'select' instead of 'depends on', >> > so do the same thing with KEXEC_FILE for consistency. >> > >> > In practice this makes very little difference as kernels with kexec >> > support are very likely to also include some other feature that already >> > selects both crypto and crypto_sha256, but being consistent here helps >> > for usability as well as to avoid potential circular dependencies. >> > >> > This reverts the dependency back to what it was originally before commit >> > 74ca317c26a3f ("kexec: create a new config option CONFIG_KEXEC_FILE for >> > new syscall"), which changed changed it with the comment "This should >> ~~~~~~~~~~~~~~ typo >> > be safer as "select" is not recursive", but that appears to have been >> > done in error, as "select" is indeed recursive, and there are no other >> > dependencies that prevent CRYPTO_SHA256 from being selected here. >> > >> > Fixes: 74ca317c26a3f ("kexec: create a new config option CONFIG_KEXEC_FILE for new syscall") >> > Cc: Herbert Xu >> > Cc: "David S. Miller" >> > Cc: linux-crypto@vger.kernel.org >> > Signed-off-by: Arnd Bergmann >> > --- >> > kernel/Kconfig.kexec | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> >> LGTM, >> >> Acked-by: Baoquan He > > Sorry, the patch 1/2 is not sent to me and kexec mailing list, so I > didn't get the intention of the entire patchset. I need hold the ack > until I read the patch 1. I have some concerns about patch 1 if I didn't > misunderstand it. Will come back later when patch 1 reviewing is > finished. Sorry about missing you on Cc. If anyone else is looking for the patch, it's archived at https://lore.kernel.org/lkml/20231023110308.1202042-1-arnd@kernel.org/ The idea of patch 1 was only to address the build regression on x86, so I was hoping that part would be uncontroversial. I split out patch 2/2 since that is intended to actually change the behavior, hopefully for the better. I introduced a new regression on riscv that Conor Dooley found, and that should already be fixed now. It looks like we may need a similar change on s390 --- a/arch/s390/Kbuild +++ b/arch/s390/Kbuild @@ -7,7 +7,7 @@ obj-$(CONFIG_S390_HYPFS) += hypfs/ obj-$(CONFIG_APPLDATA_BASE) += appldata/ obj-y += net/ obj-$(CONFIG_PCI) += pci/ -obj-$(CONFIG_ARCH_SUPPORTS_KEXEC_PURGATORY) += purgatory/ +obj-$(CONFIG_KEXEC_FILE) += purgatory/ # for cleaning subdir- += boot tools but I haven't tested that, and I'll wait for your reply then. Arnd