From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA59CC6FD18 for ; Tue, 25 Apr 2023 11:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233214AbjDYLpb (ORCPT ); Tue, 25 Apr 2023 07:45:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233451AbjDYLpb (ORCPT ); Tue, 25 Apr 2023 07:45:31 -0400 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69EBBA24C; Tue, 25 Apr 2023 04:45:21 -0700 (PDT) Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33PBcOQi021562; Tue, 25 Apr 2023 11:45:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=41hE+Q6pTHrRxzQqogU5oefxPwrJsaadBudBCLe/AhI=; b=bp3RzwB8GuPmqTT5z2d1+PPnU/04Kpa9xVc6EWpJNV4bseg3v7d0Oj2vvX2cUnN6KYvK xblxnlcKFeED4mUMMxkEbABMQOzlIaWGujilps4oTFRe50KUhYZOLjSHULsGqCST3XIj xGPHQhK2MeKdVHDCbO9rYWgByJrsq2cxLhHW/hsqpc5O1GNAQfXqRcmLLpkP6+wY3PP4 lKxlANC+X2tRhI2bsnHIbJ/p+QXbxRJ53WjrT+8e9kn55MjPtihMvL/9nV5hAQmEipYe dhYHXq5SCulaSJWGNUnpnnvg0oOLHtt2XgjkcW1PTafVRt9cCU+1Ve1AT4dv+Z0JsnzE 0Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q6dfnhhuk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Apr 2023 11:45:20 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33PBcSUF022135; Tue, 25 Apr 2023 11:45:19 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q6dfnhhtf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Apr 2023 11:45:19 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33P0X0A4017663; Tue, 25 Apr 2023 11:45:17 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3q47771pvq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Apr 2023 11:45:17 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33PBjERw27984150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Apr 2023 11:45:14 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 10F0C20043; Tue, 25 Apr 2023 11:45:14 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C14EE20040; Tue, 25 Apr 2023 11:45:13 +0000 (GMT) Received: from [9.152.222.242] (unknown [9.152.222.242]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 25 Apr 2023 11:45:13 +0000 (GMT) Message-ID: Date: Tue, 25 Apr 2023 13:45:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [kvm-unit-tests PATCH 1/1] s390x: sclp: consider monoprocessor on read_info error Content-Language: en-US To: Janosch Frank , Claudio Imbrenda Cc: linux-s390@vger.kernel.org, thuth@redhat.com, kvm@vger.kernel.org, david@redhat.com, nrb@linux.ibm.com, nsg@linux.ibm.com, cohuck@redhat.com References: <20230424174218.64145-1-pmorel@linux.ibm.com> <20230424174218.64145-2-pmorel@linux.ibm.com> <20230425102606.4e9bc606@p-imbrenda> <5572f655-4cc8-500f-97fd-068c9f06a90b@linux.ibm.com> <738a8001-a651-8e69-7985-511c28fb0485@linux.ibm.com> From: Pierre Morel In-Reply-To: <738a8001-a651-8e69-7985-511c28fb0485@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: zSB2rbGKxChJctmTYOmn5OiG2Cs8M8HI X-Proofpoint-GUID: CWkiiBxc5FRjav33VrxuMMXbn3Uvkqbd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-25_04,2023-04-25_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304250103 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On 4/25/23 13:33, Janosch Frank wrote: > On 4/25/23 12:53, Pierre Morel wrote: >> >> On 4/25/23 10:26, Claudio Imbrenda wrote: >>> On Mon, 24 Apr 2023 19:42:18 +0200 >>> Pierre Morel wrote: >>> > > How is this considered to be a fix and not a workaround? > > > Set the variable response bit in the control mask and vary the length > based on stfle 140. See __init sclp_early_read_info() in > drivers/s390/char/sclp_early_core.c Yes it is something to do anyway. Still in case of error we will need this fix or workaround. > > >>> >>>> Fixes: 52076a63d569 ("s390x: Consolidate sclp read info") >>>> Signed-off-by: Pierre Morel >>>> --- >>>>    lib/s390x/sclp.c | 5 +++-- >>>>    1 file changed, 3 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/lib/s390x/sclp.c b/lib/s390x/sclp.c >>>> index acdc8a9..c09360d 100644 >>>> --- a/lib/s390x/sclp.c >>>> +++ b/lib/s390x/sclp.c >>>> @@ -119,8 +119,9 @@ void sclp_read_info(void) >>>>       int sclp_get_cpu_num(void) >>>>    { >>>> -    assert(read_info); >>>> -    return read_info->entries_cpu; >>>> +    if (read_info) >>>> +        return read_info->entries_cpu; >>>> +    return 1; >>>>    } >>>>       CPUEntry *sclp_get_cpu_entries(void) >