From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99A0279DB5; Wed, 31 Jan 2024 11:03:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706699001; cv=none; b=JtyT6Ug5sdt+B0i9PrVMEUxZAsj4LQtKsLWcQFG4gIyZ11RVF2GgBHYyUaHa3GADLDFNUivn17EP9l/LO0nYBPLsOZBB97iTjnFb9lBbm041i9QwOXgTyaBR6Y5mBBpfnLjHD7zMYR9TYOcXsuvS+oR0IR+1/hWZsxhSs/oBGAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706699001; c=relaxed/simple; bh=w5tD2hF6VL4scoYvTlWDh0fos6f759HiGvpQ7AYLjAI=; h=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=LXB2YG4gtWYrpN5fX2dnPPX3va06A6+fwaiGM1Fo0dt65KmOR/dI8mP/wt/kdwmkWggVvTnsAUVPkc5L3pKBDeh3c0Xs6TN96JVH1vKrtVKhXqbhuFT7IjRXXUk5UKO4aeVKO2YjsHOk42NVCzvtqb5Lq61rZ8fyyimUbwmD9pM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eM5jKjqd; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eM5jKjqd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706699000; x=1738235000; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=w5tD2hF6VL4scoYvTlWDh0fos6f759HiGvpQ7AYLjAI=; b=eM5jKjqdQm8sQ40LKnBKeQGaM5Ae/8GYvptf9z6/jB8xM3mdIlpd3lUr pR+lBo3dnPRjRVNvTRCt5HuT4GTlTlSstMjWxMqaTLwjKTyvL+qNqN8uR k8uvfQczEXlmyigYwLoWDqEkTuJP/LotRaMuWiJOg+jNtmcDGmL1nCVtS FNJ+xQudFGmJCruBAMYBRnBjaGDCcl9PmO1mAZR5qp/zOfaLKZdHqqGXr TviAAz/0wj08411W7IwKN9QyQ3yEGhtC1xO2GTYk/kjyS+IwxGNQPom8W 7kaX+pS5O8PLVT17eziH3pGM1G74k59noIa0eobQ9x2onOAVWW7aYHD1J Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="16947160" X-IronPort-AV: E=Sophos;i="6.05,231,1701158400"; d="scan'208";a="16947160" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2024 03:03:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,231,1701158400"; d="scan'208";a="30460973" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.246.35.167]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2024 03:03:08 -0800 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Wed, 31 Jan 2024 13:03:04 +0200 (EET) To: Xuan Zhuo cc: virtualization@lists.linux.dev, Richard Weinberger , Anton Ivanov , Johannes Berg , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Benjamin Berg , Yang Li , linux-um@lists.infradead.org, Netdev , platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH vhost 08/17] virtio: vring_new_virtqueue(): pass struct instead of multi parameters In-Reply-To: <20240130114224.86536-9-xuanzhuo@linux.alibaba.com> Message-ID: References: <20240130114224.86536-1-xuanzhuo@linux.alibaba.com> <20240130114224.86536-9-xuanzhuo@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-s390@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 30 Jan 2024, Xuan Zhuo wrote: > Just like find_vqs(), it is time to refactor the > vring_new_virtqueue(). We pass the similar struct to > vring_new_virtqueue. > > Signed-off-by: Xuan Zhuo > --- > diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c > index 98ff808d6f0c..37f8c5d34285 100644 > --- a/tools/virtio/vringh_test.c > +++ b/tools/virtio/vringh_test.c > @@ -391,7 +391,7 @@ static int parallel_test(u64 features, > /* Swallow all notifies at once. */ > if (read(to_guest[0], buf, sizeof(buf)) < 1) > break; > - > + > receives++; > virtqueue_disable_cb(vq); > continue; > @@ -424,7 +424,7 @@ static int parallel_test(u64 features, > continue; > if (read(to_guest[0], buf, sizeof(buf)) < 1) > break; > - > + Two unrelated space changes. Please remove them from this patch. -- i.