Re: [PATCH 05/10] zfcp: restore: Dont use 0 to indicate invalid LUN in rec trace

[Hannes Reinecke <hare@suse.de>]

On 08/10/2016 06:30 PM, Steffen Maier wrote:
> bring back
> commit d21e9daa63e009ce5b87bbcaa6d11ce48e07bbbe
> ("[SCSI] zfcp: Dont use 0 to indicate invalid LUN in rec trace")
> which was lost with
> commit ae0904f60fab7cb20c48d32eefdd735e478b91fb
> ("[SCSI] zfcp: Redesign of the debug tracing for recovery actions.")
> 
> Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
> Fixes: ae0904f60fab ("[SCSI] zfcp: Redesign of the debug tracing for recovery actions.")
> Cc: <stable@vger.kernel.org> #2.6.38+
> Reviewed-by: Benjamin Block <bblock@linux.vnet.ibm.com>
> ---
>  drivers/s390/scsi/zfcp_dbf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/scsi/zfcp_dbf.c b/drivers/s390/scsi/zfcp_dbf.c
> index 2308253ddddc..e6ff199f7572 100644
> --- a/drivers/s390/scsi/zfcp_dbf.c
> +++ b/drivers/s390/scsi/zfcp_dbf.c
> @@ -241,7 +241,8 @@ static void zfcp_dbf_set_common(struct zfcp_dbf_rec *rec,
>  	if (sdev) {
>  		rec->lun_status = atomic_read(&sdev_to_zfcp(sdev)->status);
>  		rec->lun = zfcp_scsi_dev_lun(sdev);
> -	}
> +	} else
> +		rec->lun = ZFCP_DBF_INVALID_LUN;
>  }
>  
>  /**
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)