From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:49982 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726635AbgHXHh6 (ORCPT ); Mon, 24 Aug 2020 03:37:58 -0400 Subject: Re: [PATCH 3/3] nvme: don't call revalidate_disk from nvme_set_queue_dying References: <20200823091043.2600261-1-hch@lst.de> <20200823091043.2600261-4-hch@lst.de> From: Hannes Reinecke Message-ID: Date: Mon, 24 Aug 2020 09:37:56 +0200 MIME-Version: 1.0 In-Reply-To: <20200823091043.2600261-4-hch@lst.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Christoph Hellwig , Jens Axboe Cc: Justin Sanders , Josef Bacik , Xianting Tian , linux-block@vger.kernel.org, dm-devel@redhat.com, Stefan Haberland , Jan Hoeppner , linux-kernel@vger.kernel.org, nbd@other.debian.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org On 8/23/20 11:10 AM, Christoph Hellwig wrote: > In nvme_set_queue_dying we really just want to ensure the disk and bdev > sizes are set to zero. Going through revalidate_disk leads to a somewhat > arcance and complex callchain relying on special behavior in a few > places. Instead just lift the set_capacity directly to > nvme_set_queue_dying, and rename and move the nvme_mpath_update_disk_size > helper so that we can use it in nvme_set_queue_dying to propagate the > size to the bdev without detours. > > Signed-off-by: Christoph Hellwig > --- > drivers/nvme/host/core.c | 33 +++++++++++++++++++++++---------- > drivers/nvme/host/nvme.h | 13 ------------- > 2 files changed, 23 insertions(+), 23 deletions(-) > YES! I've been bitten by this far too often. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer