Re: [PATCH v4 13/24] s390/zcrypt/pkey: Rework cca findcard() implementation and callers

Holger Dengler
2025-04-11T14:16:10Z

On 09/04/2025 16:02, Harald Freudenberger wrote:
> Rework the memory usage of the cca findcard() implementation:
> - findcard does not allocate memory for the list of apqns
> any more.
> - the callers are now responsible to provide an array of
> apqns to store the matching apqns into.
>
> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>

Just a nit: Please change the component in the first line of the commit message to "s390/zcrypt:", as this is the component, where you change the API. The changes in pkey component is just an adoption of the API use.

Reviewed-by: Holger Dengler <dengler@linux.ibm.com>

--
Mit freundlichen Grüßen / Kind regards
Holger Dengler
--
IBM Systems, Linux on IBM Z Development
dengler@linux.ibm.com