Re: [PATCH v5 20/21] KVM: s390: introduce CPU feature for zPCI Interpretation

Pierre Morel
2022-04-19T10:05:13Z

On 4/4/22 19:43, Matthew Rosato wrote:
> KVM_S390_VM_CPU_FEAT_ZPCI_INTERP relays whether zPCI interpretive
> execution is possible based on the available hardware facilities.
>
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
> arch/s390/include/uapi/asm/kvm.h | 1 +
> arch/s390/kvm/kvm-s390.c | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/arch/s390/include/uapi/asm/kvm.h b/arch/s390/include/uapi/asm/kvm.h
> index 7a6b14874d65..ed06458a871f 100644
> --- a/arch/s390/include/uapi/asm/kvm.h
> +++ b/arch/s390/include/uapi/asm/kvm.h
> @@ -130,6 +130,7 @@ struct kvm_s390_vm_cpu_machine {
> #define KVM_S390_VM_CPU_FEAT_PFMFI 11
> #define KVM_S390_VM_CPU_FEAT_SIGPIF 12
> #define KVM_S390_VM_CPU_FEAT_KSS 13
> +#define KVM_S390_VM_CPU_FEAT_ZPCI_INTERP 14
> struct kvm_s390_vm_cpu_feat {
> __u64 feat[16];
> };
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 65a53e22f686..d6988bd22df8 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -433,6 +433,10 @@ static void kvm_s390_cpu_feat_init(void)
> if (test_facility(151)) /* DFLTCC */
> __insn32_query(INSN_DFLTCC, kvm_s390_available_subfunc.dfltcc);
>
> + /* zPCI Interpretation */
> + if (kvm_s390_pci_interp_allowed())
> + allow_cpu_feat(KVM_S390_VM_CPU_FEAT_ZPCI_INTERP);
> +
> if (MACHINE_HAS_ESOP)
> allow_cpu_feat(KVM_S390_VM_CPU_FEAT_ESOP);
> /*
>

Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>

--
Pierre Morel
IBM Lab Boeblingen