Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

Herbert Xu
2020-09-09T22:35:40Z

On Wed, Sep 09, 2020 at 02:09:32PM -0700, Joe Perches wrote:
> On Wed, 2020-09-09 at 13:55 -0700, Keith Busch wrote:
> > On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote:
> > > diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
> > > index eea0f453cfb6..8aac5bc60f4c 100644
> > > --- a/crypto/tcrypt.c
> > > +++ b/crypto/tcrypt.c
> > > @@ -2464,7 +2464,7 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb)
> > > test_hash_speed("streebog512", sec,
> > > generic_hash_speed_template);
> > > if (mode > 300 && mode < 400) break;
> > > - fallthrough;
> > > + break;
> > > case 399:
> > > break;
> >
> > Just imho, this change makes the preceding 'if' look even more
> > pointless. Maybe the fallthrough was a deliberate choice? Not that my
> > opinion matters here as I don't know this module, but it looked a bit
> > odd to me.
>
> It does look odd to me too.
>
> It's also just a test module though so the
> code isn't particularly crucial.
>
> Herbert/David? thoughts?

Please read the function as a whole, that fallthrough (and every other
one in do_test) needs to stay.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt