[PATCH] s390/boot: use the full title of the manual for facility bits

[PATCH] s390/boot: use the full title of the manual for facility bits

[Xose Vazquez Perez]

Also indicate the name of the section where they are listed, because it has a
length of 2124 pages:
z/Architecture Principles of Operation - Facility Indications

The current version is: Fourteenth Edition (May, 2022) SA22-7832-13

Cc: Heiko Carstens <hca@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:3/4=75%,authored:2/4=50%,added_lines:8/14=57%,removed_lines:41/47=87%)
Cc: Vasily Gorbik <gor@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%,authored:1/4=25%,added_lines:5/14=36%,removed_lines:5/47=11%)
Cc: Alexander Gordeev <agordeev@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%)
Cc: Christian Borntraeger <borntraeger@linux.ibm.com> (reviewer:S390 ARCHITECTURE)
Cc: Sven Schnelle <svens@linux.ibm.com> (reviewer:S390 ARCHITECTURE,commit_signer:2/4=50%)
Cc: S390 ML <linux-s390@vger.kernel.org> (open list:S390 ARCHITECTURE)
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 arch/s390/boot/als.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/boot/als.c b/arch/s390/boot/als.c
index 79afb5fa7f1f..7d4cec1975c6 100644
--- a/arch/s390/boot/als.c
+++ b/arch/s390/boot/als.c
@@ -65,7 +65,7 @@ static void facility_mismatch(void)
 	boot_emerg("The Linux kernel requires more recent processor hardware\n");
 	boot_emerg("Detected machine-type number: %4x\n", id.machine);
 	print_missing_facilities();
-	boot_emerg("See Principles of Operations for facility bits\n");
+	boot_emerg("For facility bits, see: z/Architecture Principles of Operation - Facility Indications\n");
 	disabled_wait();
 }
 
-- 
2.49.0

Re: [PATCH] s390/boot: use the full title of the manual for facility bits

[Heiko Carstens]

On Mon, Jun 16, 2025 at 06:32:47PM +0200, Xose Vazquez Perez wrote:
> Also indicate the name of the section where they are listed, because it has a
> length of 2124 pages:
> z/Architecture Principles of Operation - Facility Indications
> 
> The current version is: Fourteenth Edition (May, 2022) SA22-7832-13
> 
> Cc: Heiko Carstens <hca@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:3/4=75%,authored:2/4=50%,added_lines:8/14=57%,removed_lines:41/47=87%)
> Cc: Vasily Gorbik <gor@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%,authored:1/4=25%,added_lines:5/14=36%,removed_lines:5/47=11%)
> Cc: Alexander Gordeev <agordeev@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%)
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com> (reviewer:S390 ARCHITECTURE)
> Cc: Sven Schnelle <svens@linux.ibm.com> (reviewer:S390 ARCHITECTURE,commit_signer:2/4=50%)
> Cc: S390 ML <linux-s390@vger.kernel.org> (open list:S390 ARCHITECTURE)
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  arch/s390/boot/als.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/boot/als.c b/arch/s390/boot/als.c
> index 79afb5fa7f1f..7d4cec1975c6 100644
> --- a/arch/s390/boot/als.c
> +++ b/arch/s390/boot/als.c
> @@ -65,7 +65,7 @@ static void facility_mismatch(void)
>  	boot_emerg("The Linux kernel requires more recent processor hardware\n");
>  	boot_emerg("Detected machine-type number: %4x\n", id.machine);
>  	print_missing_facilities();
> -	boot_emerg("See Principles of Operations for facility bits\n");
> +	boot_emerg("For facility bits, see: z/Architecture Principles of Operation - Facility Indications\n");

Fine with me, but please let's shorten this to:

	boot_emerg("See z/Architecture Principles of Operation - Facility Indications\n");

No need to resend, I guess Alexander can change this if he agrees.

Acked-by: Heiko Carstens <hca@linux.ibm.com>

Re: [PATCH] s390/boot: use the full title of the manual for facility bits

[Alexander Gordeev]

On Mon, Jun 16, 2025 at 06:32:47PM +0200, Xose Vazquez Perez wrote:
> Also indicate the name of the section where they are listed, because it has a
> length of 2124 pages:
> z/Architecture Principles of Operation - Facility Indications
> 
> The current version is: Fourteenth Edition (May, 2022) SA22-7832-13
> 
> Cc: Heiko Carstens <hca@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:3/4=75%,authored:2/4=50%,added_lines:8/14=57%,removed_lines:41/47=87%)
> Cc: Vasily Gorbik <gor@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%,authored:1/4=25%,added_lines:5/14=36%,removed_lines:5/47=11%)
> Cc: Alexander Gordeev <agordeev@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%)
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com> (reviewer:S390 ARCHITECTURE)
> Cc: Sven Schnelle <svens@linux.ibm.com> (reviewer:S390 ARCHITECTURE,commit_signer:2/4=50%)
> Cc: S390 ML <linux-s390@vger.kernel.org> (open list:S390 ARCHITECTURE)
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  arch/s390/boot/als.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reformatted the commit message and applied.

Thanks!

Re: [PATCH] s390/boot: use the full title of the manual for facility bits

[Xose Vazquez Perez]

On 6/18/25 1:43 PM, Alexander Gordeev wrote:

> On Mon, Jun 16, 2025 at 06:32:47PM +0200, Xose Vazquez Perez wrote:
>> Also indicate the name of the section where they are listed, because it has a
>> length of 2124 pages:
>> z/Architecture Principles of Operation - Facility Indications
>>
>> The current version is: Fourteenth Edition (May, 2022) SA22-7832-13
>>
>> Cc: Heiko Carstens <hca@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:3/4=75%,authored:2/4=50%,added_lines:8/14=57%,removed_lines:41/47=87%)
>> Cc: Vasily Gorbik <gor@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%,authored:1/4=25%,added_lines:5/14=36%,removed_lines:5/47=11%)
>> Cc: Alexander Gordeev <agordeev@linux.ibm.com> (maintainer:S390 ARCHITECTURE,commit_signer:1/4=25%)
>> Cc: Christian Borntraeger <borntraeger@linux.ibm.com> (reviewer:S390 ARCHITECTURE)
>> Cc: Sven Schnelle <svens@linux.ibm.com> (reviewer:S390 ARCHITECTURE,commit_signer:2/4=50%)
>> Cc: S390 ML <linux-s390@vger.kernel.org> (open list:S390 ARCHITECTURE)
>> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
>> ---
>>   arch/s390/boot/als.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reformatted the commit message and applied.

For the record, there is a new version of the manual:
Fifteenth Edition (April, 2025) SA22-7832-14
https://www.ibm.com/docs/en/module_1678991624569/pdf/SA22-7832-14.pdf