From: David Hildenbrand <david@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Pierre Morel <pmorel@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, cohuck@redhat.com,
linux-s390@vger.kernel.org, kvm@vger.kernel.org,
frankja@linux.ibm.com, akrowiak@linux.ibm.com,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Subject: Re: [PATCH v3 2/3] KVM: s390: vsie: Do the CRYCB validation first
Date: Thu, 23 Aug 2018 13:19:21 +0200 [thread overview]
Message-ID: <cb8adf11-2bb3-4e00-ceab-f9d55c4d4f44@redhat.com> (raw)
In-Reply-To: <b7c0b0eb-c750-caeb-41b5-d6593791a6ef@de.ibm.com>
On 23.08.2018 13:17, Christian Borntraeger wrote:
>
>
> On 08/23/2018 12:25 PM, Pierre Morel wrote:
>> When entering the SIE the CRYCB validation better
>> be done independently of the instruction's
>> availability.
>
> Maybe something like
>
> We need to handle the validity checks for the crycb, no matter what the
> settings for the keywrappings are. So lets move the keywrapping checks
> after we have done the validy checks.
>
> ?
With that
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-08-23 11:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 10:25 [PATCH v3 0/3] KVM: s390: vsie: Consolidate CRYCB validation Pierre Morel
2018-08-23 10:25 ` [PATCH v3 1/3] KVM: s390: vsie: copy wrapping keys to right place Pierre Morel
2018-08-23 11:07 ` Christian Borntraeger
2018-08-23 11:19 ` David Hildenbrand
2018-08-23 11:41 ` Pierre Morel
2018-08-23 12:43 ` Christian Borntraeger
2018-08-23 12:48 ` Pierre Morel
2018-08-23 13:12 ` Christian Borntraeger
2018-08-23 13:13 ` David Hildenbrand
2018-08-23 10:25 ` [PATCH v3 2/3] KVM: s390: vsie: Do the CRYCB validation first Pierre Morel
2018-08-23 11:17 ` Christian Borntraeger
2018-08-23 11:19 ` David Hildenbrand [this message]
2018-08-23 11:42 ` Pierre Morel
2018-08-23 11:39 ` Pierre Morel
2018-08-23 13:43 ` Janosch Frank
2018-08-23 10:25 ` [PATCH v3 3/3] KVM: s390: vsie: Make use of CRYCB FORMAT2 clear Pierre Morel
2018-08-23 11:05 ` Janosch Frank
2018-08-23 11:21 ` David Hildenbrand
2018-08-23 11:33 ` Janosch Frank
2018-08-23 11:47 ` Pierre Morel
2018-08-23 11:53 ` Janosch Frank
2018-08-23 12:03 ` David Hildenbrand
2018-08-23 12:11 ` Janosch Frank
2018-08-23 11:40 ` Pierre Morel
2018-08-23 13:16 ` [PATCH v3 0/3] KVM: s390: vsie: Consolidate CRYCB validation Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb8adf11-2bb3-4e00-ceab-f9d55c4d4f44@redhat.com \
--to=david@redhat.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).