Re: [kvm-unit-tests PATCH v4 3/4] s390x: topology: Check the Perform Topology Function

Nico Boehr
2022-02-15T10:30:00Z

On Tue, 2022-02-15 at 10:44 +0100, Pierre Morel wrote:
> > > > - second operand is ignored.
> > >
> > > Which second operand?
> >
> > Sorry got it
>
> I was a little fast in my answer, twice.
> If the second operand is ignored, how would you like to check
> something
> like that?
> We can check that the result of the instruction is identical for the
> known effects the user can check what ever we put in there but how
> can
> we know if it is really ignored?

Yes, there is no 100% guarantee. If you think there is no value or it's
too difficult to test for the value it adds, it is fine for me if you
leave it out.

Your suggestion sounds fine, though.