Re: [kvm-unit-tests PATCH v4 2/4] s390x: stsi: Define vm_is_kvm to be used in different tests

Pierre Morel
2022-02-14T07:59:46Z

On 2/8/22 16:43, Nico Boehr wrote:
> On Tue, 2022-02-08 at 16:31 +0100, Janosch Frank wrote:
>>> diff --git a/lib/s390x/stsi.h b/lib/s390x/stsi.h
>>> new file mode 100644
>>> index 00000000..9b40664f
>>> --- /dev/null
>>> +++ b/lib/s390x/stsi.h
>>> @@ -0,0 +1,32 @@
>>> +/* SPDX-License-Identifier: GPL-2.0-or-later */
>>> +/*
>>> + * Structures used to Store System Information
>>> + *
>>> + * Copyright IBM Corp. 2022
>>> + */
>>> +
>>> +#ifndef _S390X_STSI_H_
>>> +#define _S390X_STSI_H_
>>> +
>>> +struct sysinfo_3_2_2 {
>>
>> Any particular reason why you renamed this?
>
> Stumbled across this as well. I think this makes it consistent with
> Linux' arch/s390/include/asm/sysinfo.h.
>
> The PoP, on the other hand, calls it SYSIB, so this at least resolves
> the inconsistency between kvm-unit-tests and Linux.
>

In fact I do not know why I renamed it probably because I coded the next
patches first and used sysinfo in it.
QEMU calls these structures SysIB so for me we do as you want.

--
Pierre Morel
IBM Lab Boeblingen